Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 214413010: Fixed crash with Multisample observer (Closed)

Created:
6 years, 9 months ago by bajones
Modified:
6 years, 9 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Fixed crash with Multisample observer BUG=333040 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170253

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/core/page/Page.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bajones
This took a stupidly long time to find this, but fortunately the solution was pretty ...
6 years, 9 months ago (2014-03-27 23:36:33 UTC) #1
Ken Russell (switch to Gerrit)
The code change LGTM, but can a test be added for this?
6 years, 9 months ago (2014-03-27 23:45:58 UTC) #2
bajones
On 2014/03/27 23:45:58, Ken Russell wrote: > The code change LGTM, but can a test ...
6 years, 9 months ago (2014-03-28 00:32:46 UTC) #3
bajones
The CQ bit was checked by bajones@chromium.org
6 years, 9 months ago (2014-03-28 00:32:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/214413010/1
6 years, 9 months ago (2014-03-28 00:33:47 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 01:36:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-28 01:36:57 UTC) #7
bajones
The CQ bit was checked by bajones@chromium.org
6 years, 9 months ago (2014-03-28 01:47:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/214413010/1
6 years, 9 months ago (2014-03-28 01:47:50 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 02:51:26 UTC) #10
Message was sent while issue was closed.
Change committed as 170253

Powered by Google App Engine
This is Rietveld 408576698