Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 214413004: Dispatch the ServiceWorker "activate" event during activation (Closed)

Created:
6 years, 9 months ago by dominicc (has gone to gerrit)
Modified:
6 years, 9 months ago
Reviewers:
falken, tkent, kinuko
CC:
blink-reviews, jsbell+serviceworker_chromium.org, jamesr, tzik, serviceworker-reviews, nhiroki, abarth-chromium, kinuko, falken, dglazkov+blink, horo+watch_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

Dispatch the ServiceWorker "activate" event during activation This will be tested by a Chromium browsertest. Service Worker plumbing that would make this possible to test in Blink isn't fitted yet. BUG=356021 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170310

Patch Set 1 #

Patch Set 2 : Workers, activate! #

Total comments: 1

Patch Set 3 : Patch for landing w/ ASSERT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -8 lines) Patch
M Source/modules/serviceworkers/InstallPhaseEvent.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/InstallPhaseEvent.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/WaitUntilObserver.h View 1 2 chunks +9 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/WaitUntilObserver.cpp View 1 3 chunks +13 lines, -4 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.cpp View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 2 chunks +11 lines, -1 line 0 comments Download
M public/web/WebServiceWorkerContextClient.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M public/web/WebServiceWorkerContextProxy.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
dominicc (has gone to gerrit)
WIP, Chromium side is <https://codereview.chromium.org/212593010/>
6 years, 9 months ago (2014-03-27 09:26:08 UTC) #1
dominicc (has gone to gerrit)
PTAL tkent: public/web, Source/web falken: Source/modules/serviceworkers
6 years, 9 months ago (2014-03-28 05:03:36 UTC) #2
falken
lgtm
6 years, 9 months ago (2014-03-28 05:19:54 UTC) #3
kinuko
(Drive-by, and lgtm2) https://codereview.chromium.org/214413004/diff/20001/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp File Source/web/ServiceWorkerGlobalScopeClientImpl.cpp (right): https://codereview.chromium.org/214413004/diff/20001/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp#newcode54 Source/web/ServiceWorkerGlobalScopeClientImpl.cpp:54: m_client->didHandleActivateEvent(eventID, result); nit: looks like our ...
6 years, 9 months ago (2014-03-28 05:24:44 UTC) #4
tkent
lgtm
6 years, 9 months ago (2014-03-28 06:09:10 UTC) #5
dominicc (has gone to gerrit)
Thank you all for the speedy reviews. kinuko: Good catch, fixed.
6 years, 9 months ago (2014-03-28 07:55:06 UTC) #6
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 9 months ago (2014-03-28 07:55:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/214413004/40001
6 years, 9 months ago (2014-03-28 07:55:18 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 08:05:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-28 08:05:48 UTC) #10
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 9 months ago (2014-03-28 10:39:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/214413004/40001
6 years, 9 months ago (2014-03-28 10:39:05 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 11:38:44 UTC) #13
Message was sent while issue was closed. 
Change committed as 170310

Powered by Google App Engine
This is Rietveld 408576698