Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2144113002: Disallow deferred loading when using isolate reloading. (Closed)

Created:
4 years, 5 months ago by turnidge
Modified:
4 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Disallow deferred loading when using isolate reloading. Update status files. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/77b99396e8c9251d816ed45eab8479dee812a397

Patch Set 1 #

Patch Set 2 : Remove unneeded files #

Total comments: 2

Patch Set 3 : Code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -55 lines) Patch
M runtime/vm/code_generator.cc View 1 chunk +7 lines, -1 line 0 comments Download
M runtime/vm/isolate_reload.cc View 1 chunk +38 lines, -15 lines 0 comments Download
M runtime/vm/object_reload.cc View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 2 chunks +26 lines, -2 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/language.status View 1 chunk +32 lines, -26 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +8 lines, -7 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
turnidge
4 years, 5 months ago (2016-07-13 22:08:15 UTC) #2
rmacnak
lgtm w/ tracking issue https://codereview.chromium.org/2144113002/diff/20001/runtime/vm/object_reload.cc File runtime/vm/object_reload.cc (right): https://codereview.chromium.org/2144113002/diff/20001/runtime/vm/object_reload.cc#newcode530 runtime/vm/object_reload.cc:530: // If the replacement library ...
4 years, 5 months ago (2016-07-13 22:19:54 UTC) #3
turnidge
https://codereview.chromium.org/2144113002/diff/20001/runtime/vm/object_reload.cc File runtime/vm/object_reload.cc (right): https://codereview.chromium.org/2144113002/diff/20001/runtime/vm/object_reload.cc#newcode530 runtime/vm/object_reload.cc:530: // If the replacement library uses deferred loading, reject ...
4 years, 5 months ago (2016-07-13 22:23:03 UTC) #4
turnidge
4 years, 5 months ago (2016-07-13 22:25:16 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
77b99396e8c9251d816ed45eab8479dee812a397 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698