third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp - Issue 2144093002: Adding checks for V8 functions returning Maybe<bool>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

Issue 2144093002: Adding checks for V8 functions returning Maybe<bool> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding NOTREACHED if Delete result IsNothing for LazyFieldGetterInner Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

index e8c989cc8b6ca449b7a771fdd7c516d480bd41e8..df4bf6d274d264e416edb9c900db2b1220ca8cb7 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

@@ -40,10 +40,12 @@ void V8PagePopupControllerBinding::installPagePopupController(v8::Local<v8::Cont

&& ContextFeatures::pagePopupEnabled(toDocument(executionContext))))

return;

- windowWrapper->SetAccessor(

+ if (windowWrapper->SetAccessor(

context,

v8AtomicString(context->GetIsolate(), "pagePopupController"),

- pagePopupControllerAttributeGetterCallback);

+ pagePopupControllerAttributeGetterCallback).IsNothing()) {

+ // TODO: What action should, if any, should be taken here?

+ }

}

} // namespace blink