third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp - Issue 2144093002: Adding checks for V8 functions returning Maybe<bool>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

Issue 2144093002: Adding checks for V8 functions returning Maybe<bool> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding NOTREACHED if Delete result IsNothing for LazyFieldGetterInner Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

index 24cb6e608abb890ee5182883145eb4c23b983bb8..1470c22e5cc0b10c3501dd66f8bdfc9c935e215f 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

@@ -904,7 +904,10 @@ void removeHiddenValueFromArray(v8::Isolate* isolate, v8::Local<v8::Object> obje

if (!array->Get(isolate->GetCurrentContext(), i).ToLocal(&item))

return;

if (item->StrictEquals(value)) {

- array->Delete(isolate->GetCurrentContext(), i);

+ if (array->Delete(isolate->GetCurrentContext(), i).IsNothing()) {

+ // TODO: Not sure if this should be logged or an error thrown or

+ // if it is fine to just return

+ }

return;

}