third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp - Issue 2144093002: Adding checks for V8 functions returning Maybe<bool>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp

Issue 2144093002: Adding checks for V8 functions returning Maybe<bool> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding checks for V8 functions returning Maybe<bool> Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp b/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp

index 2d8c532682f416d052ef8c889707d48ca24a5388..c402611078422e49fe7c9245c90d9a4612537e11 100644

--- a/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp

@@ -401,7 +401,7 @@ void LocalWindowProxy::namedItemAdded(HTMLDocument* document,

// name already exists or not, and if it exists, we shouldn't define a new

// accessor property (it fails).

documentWrapper->SetAccessor(isolate()->GetCurrentContext(),

- v8String(isolate(), name), getter);

+ v8String(isolate(), name), getter).ToChecked();

}

void LocalWindowProxy::namedItemRemoved(HTMLDocument* document,

« no previous file with comments | « extensions/renderer/module_system.cc ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp » ('j') | no next file with comments »