Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2144083002: mash: Move user_switch_util to chrome. (Closed)

Created:
4 years, 5 months ago by msw
Modified:
4 years, 5 months ago
Reviewers:
James Cook, sky
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move user_switch_util to chrome. Move nearer use in session_state_delegate_chromeos.cc. A temporary/punt measure to avoid some minor issues. It'll need to communicate w/ash for share/capture stuff. Avoids SystemTray access and dialog conversion tasks. BUG=619636 TEST=compiles; unit tests; no behavior changes. R=jamescook@chromium.org TBR=sky@chromium.org Committed: https://crrev.com/47b22eb9317cfd04c39dc20aaa94418aa4749b37 Cr-Commit-Position: refs/heads/master@{#405288}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -466 lines) Patch
M ash/ash.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
D ash/system/chromeos/multi_user/user_switch_util.h View 1 chunk +0 lines, -26 lines 0 comments Download
D ash/system/chromeos/multi_user/user_switch_util.cc View 1 chunk +0 lines, -197 lines 0 comments Download
D ash/system/chromeos/multi_user/user_switch_util_unittest.cc View 1 chunk +0 lines, -215 lines 0 comments Download
A + chrome/browser/ui/ash/multi_user/user_switch_util.h View 1 chunk +5 lines, -11 lines 0 comments Download
A + chrome/browser/ui/ash/multi_user/user_switch_util.cc View 6 chunks +7 lines, -9 lines 2 comments Download
A + chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
msw
Hey James, please take a look; thanks!
4 years, 5 months ago (2016-07-13 19:15:22 UTC) #2
James Cook
LGTM https://codereview.chromium.org/2144083002/diff/1/chrome/browser/ui/ash/multi_user/user_switch_util.cc File chrome/browser/ui/ash/multi_user/user_switch_util.cc (right): https://codereview.chromium.org/2144083002/diff/1/chrome/browser/ui/ash/multi_user/user_switch_util.cc#newcode32 chrome/browser/ui/ash/multi_user/user_switch_util.cc:32: explicit DesktopCastingWarningView(base::Callback<void()> on_accept); Thanks for fixing. (Out of ...
4 years, 5 months ago (2016-07-13 19:26:06 UTC) #5
msw
https://codereview.chromium.org/2144083002/diff/1/chrome/browser/ui/ash/multi_user/user_switch_util.cc File chrome/browser/ui/ash/multi_user/user_switch_util.cc (right): https://codereview.chromium.org/2144083002/diff/1/chrome/browser/ui/ash/multi_user/user_switch_util.cc#newcode32 chrome/browser/ui/ash/multi_user/user_switch_util.cc:32: explicit DesktopCastingWarningView(base::Callback<void()> on_accept); On 2016/07/13 19:26:06, James Cook wrote: ...
4 years, 5 months ago (2016-07-13 19:31:52 UTC) #6
msw
+TBR Scott for simple chrome/* changes.
4 years, 5 months ago (2016-07-13 19:32:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144083002/1
4 years, 5 months ago (2016-07-13 21:11:24 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 21:27:10 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 21:30:21 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47b22eb9317cfd04c39dc20aaa94418aa4749b37
Cr-Commit-Position: refs/heads/master@{#405288}

Powered by Google App Engine
This is Rietveld 408576698