Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: tools/perf/benchmarks/v8_browsing.py

Issue 2144073004: [system-health] Unify SH stories interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Restrict story selector Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/v8_browsing.py
diff --git a/tools/perf/benchmarks/v8_browsing.py b/tools/perf/benchmarks/v8_browsing.py
index 9d2152fa9a36b160886ff9c3884c3a83a03987d6..29787ac9ceb338bc8aa6f68863bc74ab63b5fbd5 100644
--- a/tools/perf/benchmarks/v8_browsing.py
+++ b/tools/perf/benchmarks/v8_browsing.py
@@ -58,9 +58,12 @@ class _V8BrowsingBenchmark(perf_benchmark.PerfBenchmark):
options.SetTimelineBasedMetrics(['v8AndMemoryMetrics'])
return options
+ def CreateStorySet(self, options):
+ return page_sets.SystemHealthStorySet(platform=self.PLATFORM, case='browse')
+
@classmethod
def Name(cls):
- return 'v8.browsing_%s' % cls.page_set.PLATFORM
+ return 'v8.browsing_%s' % cls.PLATFORM
@classmethod
def ValueCanBeAddedPredicate(cls, value, is_first_result):
@@ -78,7 +81,7 @@ class _V8BrowsingBenchmark(perf_benchmark.PerfBenchmark):
class V8DesktopBrowsingBenchmark(_V8BrowsingBenchmark):
- page_set = page_sets.DesktopBrowsingSystemHealthStorySet
+ PLATFORM = 'desktop'
@classmethod
def ShouldDisable(cls, possible_browser):
@@ -86,7 +89,7 @@ class V8DesktopBrowsingBenchmark(_V8BrowsingBenchmark):
class V8MobileBrowsingBenchmark(_V8BrowsingBenchmark):
- page_set = page_sets.MobileBrowsingSystemHealthStorySet
+ PLATFORM = 'mobile'
@classmethod
def ShouldDisable(cls, possible_browser):

Powered by Google App Engine
This is Rietveld 408576698