third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h - Issue 2144073002: Using WeakMember<Element> in ElementVisibilityObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h

Issue 2144073002: Using WeakMember<Element> in ElementVisibilityObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h

diff --git a/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h b/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h

index be62f5bc2218b4f15e4215628d302ade4320001d..7809b89f3a5f73659128d712bbda78e6e5ec8d3e 100644

--- a/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h

+++ b/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h

@@ -40,7 +40,7 @@ private:

void onVisibilityChanged(const HeapVector<Member<IntersectionObserverEntry>>&);

- Member<Element> m_element;

+ WeakMember<Element> m_element;

Member<IntersectionObserver> m_intersectionObserver;

std::unique_ptr<VisibilityCallback> m_callback;

};

« no previous file with comments | « no previous file | no next file » | no next file with comments »