Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 2144063003: [turbofan] Remove obsolete frame state before comparison. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove obsolete frame state before comparison. This removes the obsolete use of FrameStateBeforeAndAfter when visiting compare operations. None of the operators in question require a "before" frame state by now. R=jarin@chromium.org Committed: https://crrev.com/fa8d4346e60bebb7f348a6ee6860b1e72fd3e3ec Cr-Commit-Position: refs/heads/master@{#37771}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael Starzinger
4 years, 5 months ago (2016-07-14 14:14:42 UTC) #2
Jarin
lgtm
4 years, 5 months ago (2016-07-14 14:58:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144063003/1
4 years, 5 months ago (2016-07-14 15:33:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 15:35:11 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 15:35:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa8d4346e60bebb7f348a6ee6860b1e72fd3e3ec
Cr-Commit-Position: refs/heads/master@{#37771}

Powered by Google App Engine
This is Rietveld 408576698