Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Unified Diff: third_party/WebKit/Source/modules/mediasource/MediaSource.cpp

Issue 2144063002: MSE: Remove check for not 'updating' in {set,clear}LiveSeekableRange() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
diff --git a/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp b/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
index ba2964942de764957c9bc970308265e1ee235388..e0045414e4c3bc963a976856d31852220b72be68 100644
--- a/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
+++ b/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
@@ -530,7 +530,10 @@ void MediaSource::setLiveSeekableRange(double start, double end, ExceptionState&
// 2. If the updating attribute equals true on any SourceBuffer in
// SourceBuffers, then throw an InvalidStateError exception and abort
// these steps.
- if (throwExceptionIfClosedOrUpdating(isOpen(), isUpdating(), exceptionState))
+ // Note: With anticipated change to remove this 'updating' check to fix
chcunningham 2016/07/13 19:24:06 Nit: this is hard to read. If you make a separate
wolenetz 2016/07/13 19:51:54 Done.
+ // spec issue https://github.com/w3c/media-source/issues/118, this method
+ // fakes that we are not 'updating' to pass that check.
+ if (throwExceptionIfClosedOrUpdating(isOpen(), false, exceptionState))
return;
// 3. If start is negative or greater than end, then throw a TypeError
@@ -554,7 +557,10 @@ void MediaSource::clearLiveSeekableRange(ExceptionState& exceptionState)
// 2. If the updating attribute equals true on any SourceBuffer in
// SourceBuffers, then throw an InvalidStateError exception and abort
// these steps.
- if (throwExceptionIfClosedOrUpdating(isOpen(), isUpdating(), exceptionState))
+ // Note: With anticipated change to remove this 'updating' check to fix
+ // spec issue https://github.com/w3c/media-source/issues/118, this method
+ // fakes that we are not 'updating' to pass that check.
+ if (throwExceptionIfClosedOrUpdating(isOpen(), false, exceptionState))
return;
// 3. If live seekable range contains a range, then set live seekable range
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698