|
|
Created:
4 years, 5 months ago by Robert Sesek Modified:
4 years, 5 months ago CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRedeclare symbols to fix partial availability warnings in //chrome/installer/mac/.
../../chrome/installer/mac/app/NetworkCommunication.m:48:17: error: 'dataTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability]
[session_ dataTaskWithRequest:request_
^
/Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:203:1: note: 'dataTaskWithRequest:completionHandler:' has been explicitly marked partial here
- (NSURLSessionDataTask *)dataTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSData *data, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0);
^
../../chrome/installer/mac/app/NetworkCommunication.m:48:17: note: explicitly redeclare 'dataTaskWithRequest:completionHandler:' to silence this warning
[session_ dataTaskWithRequest:request_
^
../../chrome/installer/mac/app/NetworkCommunication.m:57:30: error: 'downloadTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability]
downloadTask = [session_ downloadTaskWithRequest:request_
^
/Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:218:1: note: 'downloadTaskWithRequest:completionHandler:' has been explicitly marked partial here
- (NSURLSessionDownloadTask *)downloadTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSURL *location, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0);
^
../../chrome/installer/mac/app/NetworkCommunication.m:57:30: note: explicitly redeclare 'downloadTaskWithRequest:completionHandler:' to silence this warning
downloadTask = [session_ downloadTaskWithRequest:request_
^
R=dpranke@chromium.org, mark@chromium.org
BUG=627890
Committed: https://chromium.googlesource.com/chromium/src/+/f4b46ec406d7703de227a09dfd373ee3d25cc01c
Patch Set 1 #
Messages
Total messages: 12 (7 generated)
Description was changed from ========== Redeclare symbols to fix partial availibilty warnings in //chrome/installer/mac/. ../../chrome/installer/mac/app/NetworkCommunication.m:48:17: error: 'dataTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability] [session_ dataTaskWithRequest:request_ ^ /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:203:1: note: 'dataTaskWithRequest:completionHandler:' has been explicitly marked partial here - (NSURLSessionDataTask *)dataTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSData *data, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0); ^ ../../chrome/installer/mac/app/NetworkCommunication.m:48:17: note: explicitly redeclare 'dataTaskWithRequest:completionHandler:' to silence this warning [session_ dataTaskWithRequest:request_ ^ ../../chrome/installer/mac/app/NetworkCommunication.m:57:30: error: 'downloadTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability] downloadTask = [session_ downloadTaskWithRequest:request_ ^ /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:218:1: note: 'downloadTaskWithRequest:completionHandler:' has been explicitly marked partial here - (NSURLSessionDownloadTask *)downloadTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSURL *location, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0); ^ ../../chrome/installer/mac/app/NetworkCommunication.m:57:30: note: explicitly redeclare 'downloadTaskWithRequest:completionHandler:' to silence this warning downloadTask = [session_ downloadTaskWithRequest:request_ ^ R=mark@chromium.org BUG= ========== to ========== Redeclare symbols to fix partial availibilty warnings in //chrome/installer/mac/. ../../chrome/installer/mac/app/NetworkCommunication.m:48:17: error: 'dataTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability] [session_ dataTaskWithRequest:request_ ^ /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:203:1: note: 'dataTaskWithRequest:completionHandler:' has been explicitly marked partial here - (NSURLSessionDataTask *)dataTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSData *data, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0); ^ ../../chrome/installer/mac/app/NetworkCommunication.m:48:17: note: explicitly redeclare 'dataTaskWithRequest:completionHandler:' to silence this warning [session_ dataTaskWithRequest:request_ ^ ../../chrome/installer/mac/app/NetworkCommunication.m:57:30: error: 'downloadTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability] downloadTask = [session_ downloadTaskWithRequest:request_ ^ /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:218:1: note: 'downloadTaskWithRequest:completionHandler:' has been explicitly marked partial here - (NSURLSessionDownloadTask *)downloadTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSURL *location, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0); ^ ../../chrome/installer/mac/app/NetworkCommunication.m:57:30: note: explicitly redeclare 'downloadTaskWithRequest:completionHandler:' to silence this warning downloadTask = [session_ downloadTaskWithRequest:request_ ^ R=mark@chromium.org BUG=627890 ==========
The CQ bit was checked by rsesek@chromium.org to run a CQ dry run
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Redeclare symbols to fix partial availibilty warnings in //chrome/installer/mac/. ../../chrome/installer/mac/app/NetworkCommunication.m:48:17: error: 'dataTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability] [session_ dataTaskWithRequest:request_ ^ /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:203:1: note: 'dataTaskWithRequest:completionHandler:' has been explicitly marked partial here - (NSURLSessionDataTask *)dataTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSData *data, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0); ^ ../../chrome/installer/mac/app/NetworkCommunication.m:48:17: note: explicitly redeclare 'dataTaskWithRequest:completionHandler:' to silence this warning [session_ dataTaskWithRequest:request_ ^ ../../chrome/installer/mac/app/NetworkCommunication.m:57:30: error: 'downloadTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability] downloadTask = [session_ downloadTaskWithRequest:request_ ^ /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:218:1: note: 'downloadTaskWithRequest:completionHandler:' has been explicitly marked partial here - (NSURLSessionDownloadTask *)downloadTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSURL *location, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0); ^ ../../chrome/installer/mac/app/NetworkCommunication.m:57:30: note: explicitly redeclare 'downloadTaskWithRequest:completionHandler:' to silence this warning downloadTask = [session_ downloadTaskWithRequest:request_ ^ R=mark@chromium.org BUG=627890 ========== to ========== Redeclare symbols to fix partial availability warnings in //chrome/installer/mac/. ../../chrome/installer/mac/app/NetworkCommunication.m:48:17: error: 'dataTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability] [session_ dataTaskWithRequest:request_ ^ /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:203:1: note: 'dataTaskWithRequest:completionHandler:' has been explicitly marked partial here - (NSURLSessionDataTask *)dataTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSData *data, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0); ^ ../../chrome/installer/mac/app/NetworkCommunication.m:48:17: note: explicitly redeclare 'dataTaskWithRequest:completionHandler:' to silence this warning [session_ dataTaskWithRequest:request_ ^ ../../chrome/installer/mac/app/NetworkCommunication.m:57:30: error: 'downloadTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability] downloadTask = [session_ downloadTaskWithRequest:request_ ^ /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:218:1: note: 'downloadTaskWithRequest:completionHandler:' has been explicitly marked partial here - (NSURLSessionDownloadTask *)downloadTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSURL *location, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0); ^ ../../chrome/installer/mac/app/NetworkCommunication.m:57:30: note: explicitly redeclare 'downloadTaskWithRequest:completionHandler:' to silence this warning downloadTask = [session_ downloadTaskWithRequest:request_ ^ R=mark@chromium.org BUG=627890 ==========
LGTM
Message was sent while issue was closed.
Description was changed from ========== Redeclare symbols to fix partial availability warnings in //chrome/installer/mac/. ../../chrome/installer/mac/app/NetworkCommunication.m:48:17: error: 'dataTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability] [session_ dataTaskWithRequest:request_ ^ /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:203:1: note: 'dataTaskWithRequest:completionHandler:' has been explicitly marked partial here - (NSURLSessionDataTask *)dataTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSData *data, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0); ^ ../../chrome/installer/mac/app/NetworkCommunication.m:48:17: note: explicitly redeclare 'dataTaskWithRequest:completionHandler:' to silence this warning [session_ dataTaskWithRequest:request_ ^ ../../chrome/installer/mac/app/NetworkCommunication.m:57:30: error: 'downloadTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability] downloadTask = [session_ downloadTaskWithRequest:request_ ^ /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:218:1: note: 'downloadTaskWithRequest:completionHandler:' has been explicitly marked partial here - (NSURLSessionDownloadTask *)downloadTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSURL *location, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0); ^ ../../chrome/installer/mac/app/NetworkCommunication.m:57:30: note: explicitly redeclare 'downloadTaskWithRequest:completionHandler:' to silence this warning downloadTask = [session_ downloadTaskWithRequest:request_ ^ R=mark@chromium.org BUG=627890 ========== to ========== Redeclare symbols to fix partial availability warnings in //chrome/installer/mac/. ../../chrome/installer/mac/app/NetworkCommunication.m:48:17: error: 'dataTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability] [session_ dataTaskWithRequest:request_ ^ /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:203:1: note: 'dataTaskWithRequest:completionHandler:' has been explicitly marked partial here - (NSURLSessionDataTask *)dataTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSData *data, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0); ^ ../../chrome/installer/mac/app/NetworkCommunication.m:48:17: note: explicitly redeclare 'dataTaskWithRequest:completionHandler:' to silence this warning [session_ dataTaskWithRequest:request_ ^ ../../chrome/installer/mac/app/NetworkCommunication.m:57:30: error: 'downloadTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability] downloadTask = [session_ downloadTaskWithRequest:request_ ^ /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:218:1: note: 'downloadTaskWithRequest:completionHandler:' has been explicitly marked partial here - (NSURLSessionDownloadTask *)downloadTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSURL *location, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0); ^ ../../chrome/installer/mac/app/NetworkCommunication.m:57:30: note: explicitly redeclare 'downloadTaskWithRequest:completionHandler:' to silence this warning downloadTask = [session_ downloadTaskWithRequest:request_ ^ R=dpranke@chromium.org, mark@chromium.org BUG=627890 Committed: https://crrev.com/f4b46ec406d7703de227a09dfd373ee3d25cc01c Cr-Commit-Position: refs/heads/master@{#405219} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f4b46ec406d7703de227a09dfd373ee3d25cc01c Cr-Commit-Position: refs/heads/master@{#405219}
Message was sent while issue was closed.
Description was changed from ========== Redeclare symbols to fix partial availability warnings in //chrome/installer/mac/. ../../chrome/installer/mac/app/NetworkCommunication.m:48:17: error: 'dataTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability] [session_ dataTaskWithRequest:request_ ^ /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:203:1: note: 'dataTaskWithRequest:completionHandler:' has been explicitly marked partial here - (NSURLSessionDataTask *)dataTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSData *data, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0); ^ ../../chrome/installer/mac/app/NetworkCommunication.m:48:17: note: explicitly redeclare 'dataTaskWithRequest:completionHandler:' to silence this warning [session_ dataTaskWithRequest:request_ ^ ../../chrome/installer/mac/app/NetworkCommunication.m:57:30: error: 'downloadTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability] downloadTask = [session_ downloadTaskWithRequest:request_ ^ /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:218:1: note: 'downloadTaskWithRequest:completionHandler:' has been explicitly marked partial here - (NSURLSessionDownloadTask *)downloadTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSURL *location, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0); ^ ../../chrome/installer/mac/app/NetworkCommunication.m:57:30: note: explicitly redeclare 'downloadTaskWithRequest:completionHandler:' to silence this warning downloadTask = [session_ downloadTaskWithRequest:request_ ^ R=dpranke@chromium.org, mark@chromium.org BUG=627890 Committed: https://crrev.com/f4b46ec406d7703de227a09dfd373ee3d25cc01c Cr-Commit-Position: refs/heads/master@{#405219} ========== to ========== Redeclare symbols to fix partial availability warnings in //chrome/installer/mac/. ../../chrome/installer/mac/app/NetworkCommunication.m:48:17: error: 'dataTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability] [session_ dataTaskWithRequest:request_ ^ /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:203:1: note: 'dataTaskWithRequest:completionHandler:' has been explicitly marked partial here - (NSURLSessionDataTask *)dataTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSData *data, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0); ^ ../../chrome/installer/mac/app/NetworkCommunication.m:48:17: note: explicitly redeclare 'dataTaskWithRequest:completionHandler:' to silence this warning [session_ dataTaskWithRequest:request_ ^ ../../chrome/installer/mac/app/NetworkCommunication.m:57:30: error: 'downloadTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability] downloadTask = [session_ downloadTaskWithRequest:request_ ^ /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:218:1: note: 'downloadTaskWithRequest:completionHandler:' has been explicitly marked partial here - (NSURLSessionDownloadTask *)downloadTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSURL *location, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0); ^ ../../chrome/installer/mac/app/NetworkCommunication.m:57:30: note: explicitly redeclare 'downloadTaskWithRequest:completionHandler:' to silence this warning downloadTask = [session_ downloadTaskWithRequest:request_ ^ R=dpranke@chromium.org, mark@chromium.org BUG=627890 Committed: https://chromium.googlesource.com/chromium/src/+/f4b46ec406d7703de227a09dfd37... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as f4b46ec406d7703de227a09dfd373ee3d25cc01c (presubmit successful). |