Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2144033002: Redeclare symbols to fix partial availability warnings in //chrome/installer/mac/. (Closed)

Created:
4 years, 5 months ago by Robert Sesek
Modified:
4 years, 5 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Redeclare symbols to fix partial availability warnings in //chrome/installer/mac/. ../../chrome/installer/mac/app/NetworkCommunication.m:48:17: error: 'dataTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability] [session_ dataTaskWithRequest:request_ ^ /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:203:1: note: 'dataTaskWithRequest:completionHandler:' has been explicitly marked partial here - (NSURLSessionDataTask *)dataTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSData *data, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0); ^ ../../chrome/installer/mac/app/NetworkCommunication.m:48:17: note: explicitly redeclare 'dataTaskWithRequest:completionHandler:' to silence this warning [session_ dataTaskWithRequest:request_ ^ ../../chrome/installer/mac/app/NetworkCommunication.m:57:30: error: 'downloadTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability] downloadTask = [session_ downloadTaskWithRequest:request_ ^ /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:218:1: note: 'downloadTaskWithRequest:completionHandler:' has been explicitly marked partial here - (NSURLSessionDownloadTask *)downloadTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSURL *location, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0); ^ ../../chrome/installer/mac/app/NetworkCommunication.m:57:30: note: explicitly redeclare 'downloadTaskWithRequest:completionHandler:' to silence this warning downloadTask = [session_ downloadTaskWithRequest:request_ ^ R=dpranke@chromium.org, mark@chromium.org BUG=627890 Committed: https://chromium.googlesource.com/chromium/src/+/f4b46ec406d7703de227a09dfd373ee3d25cc01c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/installer/mac/app/NetworkCommunication.m View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Robert Sesek
4 years, 5 months ago (2016-07-13 17:51:09 UTC) #2
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-13 17:51:39 UTC) #5
Mark Mentovai
LGTM
4 years, 5 months ago (2016-07-13 17:57:54 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f4b46ec406d7703de227a09dfd373ee3d25cc01c Cr-Commit-Position: refs/heads/master@{#405219}
4 years, 5 months ago (2016-07-13 18:01:55 UTC) #10
Robert Sesek
4 years, 5 months ago (2016-07-13 18:04:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f4b46ec406d7703de227a09dfd373ee3d25cc01c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698