Make it possible to enable blink_gc_plugin on mac.

Make it possible to enable blink_gc_plugin on mac.

We were missing the xcode_settings OTHER_CFLAGS.

R=oilpan-reviews@chromium.org, tkent@chromium.org, zerny@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170222

[Mads Ager (chromium), 2014-03-27 07:53:19]

Adding Adam for OWNER review.

[haraken, 2014-03-27 08:39:49]

LGTM

[zerny-chromium, 2014-03-27 08:50:10]

lgtm

[Nico, 2014-03-27 15:26:00]

I don't think you need the clang_xcode check, the plugin check should be enough?

[Mads Ager (chromium), 2014-03-27 16:21:07]

That was following what is done for the other plugin. I guess we cannot use
the plugin if we are using a version of clang shipped with xcode instead of
our own? But maybe we don't care?
On Mar 27, 2014 4:26 PM, <thakis@chromium.org> wrote:

> I don't think you need the clang_xcode check, the plugin check should be
> enough?
>
> https://codereview.chromium.org/214403002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Nico, 2014-03-27 16:41:02]

On 2014/03/27 16:21:07, Mads Ager (chromium) wrote:
> That was following what is done for the other plugin.

Ah, lame.

> I guess we cannot use
> the plugin if we are using a version of clang shipped with xcode instead of
> our own?

I thought lang_use_chrome_plugins would be set to 0 for xcode clang. Apparently
not.

> But maybe we don't care?

Probably not, xcode_clang is only used by chrome/ios, and they don't build
blink.

> On Mar 27, 2014 4:26 PM, <mailto:thakis@chromium.org> wrote:
> 
> > I don't think you need the clang_xcode check, the plugin check should be
> > enough?
> >
> > https://codereview.chromium.org/214403002/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:blink-reviews+unsubscribe@chromium.org.

[Mads Ager (chromium), 2014-03-27 17:00:10]

On 2014/03/27 16:41:02, Nico wrote:
> On 2014/03/27 16:21:07, Mads Ager (chromium) wrote:
> > That was following what is done for the other plugin.
> 
> Ah, lame.
> 
> > I guess we cannot use
> > the plugin if we are using a version of clang shipped with xcode instead of
> > our own?
> 
> I thought lang_use_chrome_plugins would be set to 0 for xcode clang.
Apparently
> not.
> 
> > But maybe we don't care?
> 
> Probably not, xcode_clang is only used by chrome/ios, and they don't build
> blink.

Thanks Nico. clang_xcode condition removed. :)

[abarth-chromium, 2014-03-27 21:03:42]

rslgtm assuming Nico is happy.

[Nico, 2014-03-27 21:07:44]

patch set 2 lgtm, yes

[Nico, 2014-03-27 21:07:52]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-03-27 21:08:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ager@chromium.org/214403002/20001

[commit-bot: I haz the power, 2014-03-27 22:33:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 22:33:03]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[Nico, 2014-03-27 22:38:23]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-03-27 22:40:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ager@chromium.org/214403002/20001

[commit-bot: I haz the power, 2014-03-27 23:47:31]

Change committed as 170222