Reland of arc: Use the new InstanceHolder for unittests

Reland of arc: Use the new InstanceHolder for unittests (patchset #1 id:1 of https://codereview.chromium.org/2146573005/ )

Reason for revert:
https://codereview.chromium.org/2150583002 should fix the underlying issue that this change surfaced.

Original issue's description:
> Revert of arc: Use the new InstanceHolder for unittests (patchset #4 id:60001 of https://codereview.chromium.org/2138513002/ )
>
> Reason for revert:
> Caused unit_tests failure on Linux ChromiumOS Tests (1):
>
> ArcAppModelBuilderTest.RemoveAppCleanUpFolder
>
> Original issue's description:
> > arc: Use the new InstanceHolder for unittests
> >
> > Instead of having unit tests go through Mojo and jump through hoops to
> > ensure that all messages have propagated to all the threads, we can use
> > the new arc::ArcBridgeService::InstanceHolder<T>::SetInstance() to
> > directly set the concrete fake (and optional version). This simplifies
> > testing quite a bit.
> >
> > BUG=626695
> > TEST=trybots
> >
> > Committed: https://crrev.com/c5fffc64c14a0464f8870bbe91df7e945f42c3ca
> > Cr-Commit-Position: refs/heads/master@{#405138}
>
> TBR=hidehiko@chromium.org,stevenjb@chromium.org,lhchavez@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=626695
>
> Committed: https://crrev.com/03b1e37434a736bbb5c764dd980787e54c93868b
> Cr-Commit-Position: refs/heads/master@{#405165}

Committed: https://crrev.com/5aa0d0ed4da47326e168783b8251d8fbf0c58add
Cr-Commit-Position: refs/heads/master@{#405785}

[Luis Héctor Chávez, 2016-07-13 16:24:52]

Created Reland of arc: Use the new InstanceHolder for unittests

[hidehiko, 2016-07-13 16:42:50]

LGTM.

Please wait for the fix is landed,
and please rebase and re-run trybots after the fix.

Thank you for quick work!

[stevenjb, 2016-07-13 17:36:40]

c/b/ui lgtm

[Luis Héctor Chávez, 2016-07-15 14:52:17]

Description was changed from

==========
Reland of arc: Use the new InstanceHolder for unittests (patchset #1 id:1 of
https://codereview.chromium.org/2146573005/ )

Reason for revert:
https://codereview.chromium.org/2150583002 should fix the underlying issue that
this change surfaced.

Original issue's description:
> Revert of arc: Use the new InstanceHolder for unittests (patchset #4 id:60001
of https://codereview.chromium.org/2138513002/ )
> 
> Reason for revert:
> Caused unit_tests failure on Linux ChromiumOS Tests (1):
> 
> ArcAppModelBuilderTest.RemoveAppCleanUpFolder
> 
> Original issue's description:
> > arc: Use the new InstanceHolder for unittests
> >
> > Instead of having unit tests go through Mojo and jump through hoops to
> > ensure that all messages have propagated to all the threads, we can use
> > the new arc::ArcBridgeService::InstanceHolder<T>::SetInstance() to
> > directly set the concrete fake (and optional version). This simplifies
> > testing quite a bit.
> >
> > BUG=626695
> > TEST=trybots
> >
> > Committed: https://crrev.com/c5fffc64c14a0464f8870bbe91df7e945f42c3ca
> > Cr-Commit-Position: refs/heads/master@{#405138}
> 
> TBR=hidehiko@chromium.org,stevenjb@chromium.org,lhchavez@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=626695
> 
> Committed: https://crrev.com/03b1e37434a736bbb5c764dd980787e54c93868b
> Cr-Commit-Position: refs/heads/master@{#405165}

TBR=hidehiko@chromium.org,stevenjb@chromium.org,engedy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=626695
==========

to

==========
Reland of arc: Use the new InstanceHolder for unittests (patchset #1 id:1 of
https://codereview.chromium.org/2146573005/ )

Reason for revert:
https://codereview.chromium.org/2150583002 should fix the underlying issue that
this change surfaced.

Original issue's description:
> Revert of arc: Use the new InstanceHolder for unittests (patchset #4 id:60001
of https://codereview.chromium.org/2138513002/ )
> 
> Reason for revert:
> Caused unit_tests failure on Linux ChromiumOS Tests (1):
> 
> ArcAppModelBuilderTest.RemoveAppCleanUpFolder
> 
> Original issue's description:
> > arc: Use the new InstanceHolder for unittests
> >
> > Instead of having unit tests go through Mojo and jump through hoops to
> > ensure that all messages have propagated to all the threads, we can use
> > the new arc::ArcBridgeService::InstanceHolder<T>::SetInstance() to
> > directly set the concrete fake (and optional version). This simplifies
> > testing quite a bit.
> >
> > BUG=626695
> > TEST=trybots
> >
> > Committed: https://crrev.com/c5fffc64c14a0464f8870bbe91df7e945f42c3ca
> > Cr-Commit-Position: refs/heads/master@{#405138}
> 
> TBR=hidehiko@chromium.org,stevenjb@chromium.org,lhchavez@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=626695
> 
> Committed: https://crrev.com/03b1e37434a736bbb5c764dd980787e54c93868b
> Cr-Commit-Position: refs/heads/master@{#405165}
==========

[Luis Héctor Chávez, 2016-07-15 14:52:17]

lhchavez@chromium.org changed reviewers:
- engedy@chromium.org

[Luis Héctor Chávez, 2016-07-15 14:58:12]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 14:58:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 15:16:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 15:16:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Luis Héctor Chávez, 2016-07-15 15:33:19]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 15:33:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 17:47:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 17:47:53]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Luis Héctor Chávez, 2016-07-15 17:49:09]

The CQ bit was checked by lhchavez@chromium.org

[Luis Héctor Chávez, 2016-07-15 17:49:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
hidehiko@chromium.org, stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2144013002/#ps270001
(title: "Fixed bad merge")

[commit-bot: I haz the power, 2016-07-15 17:49:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 17:56:00]

Description was changed from

==========
Reland of arc: Use the new InstanceHolder for unittests (patchset #1 id:1 of
https://codereview.chromium.org/2146573005/ )

Reason for revert:
https://codereview.chromium.org/2150583002 should fix the underlying issue that
this change surfaced.

Original issue's description:
> Revert of arc: Use the new InstanceHolder for unittests (patchset #4 id:60001
of https://codereview.chromium.org/2138513002/ )
> 
> Reason for revert:
> Caused unit_tests failure on Linux ChromiumOS Tests (1):
> 
> ArcAppModelBuilderTest.RemoveAppCleanUpFolder
> 
> Original issue's description:
> > arc: Use the new InstanceHolder for unittests
> >
> > Instead of having unit tests go through Mojo and jump through hoops to
> > ensure that all messages have propagated to all the threads, we can use
> > the new arc::ArcBridgeService::InstanceHolder<T>::SetInstance() to
> > directly set the concrete fake (and optional version). This simplifies
> > testing quite a bit.
> >
> > BUG=626695
> > TEST=trybots
> >
> > Committed: https://crrev.com/c5fffc64c14a0464f8870bbe91df7e945f42c3ca
> > Cr-Commit-Position: refs/heads/master@{#405138}
> 
> TBR=hidehiko@chromium.org,stevenjb@chromium.org,lhchavez@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=626695
> 
> Committed: https://crrev.com/03b1e37434a736bbb5c764dd980787e54c93868b
> Cr-Commit-Position: refs/heads/master@{#405165}
==========

to

==========
Reland of arc: Use the new InstanceHolder for unittests (patchset #1 id:1 of
https://codereview.chromium.org/2146573005/ )

Reason for revert:
https://codereview.chromium.org/2150583002 should fix the underlying issue that
this change surfaced.

Original issue's description:
> Revert of arc: Use the new InstanceHolder for unittests (patchset #4 id:60001
of https://codereview.chromium.org/2138513002/ )
> 
> Reason for revert:
> Caused unit_tests failure on Linux ChromiumOS Tests (1):
> 
> ArcAppModelBuilderTest.RemoveAppCleanUpFolder
> 
> Original issue's description:
> > arc: Use the new InstanceHolder for unittests
> >
> > Instead of having unit tests go through Mojo and jump through hoops to
> > ensure that all messages have propagated to all the threads, we can use
> > the new arc::ArcBridgeService::InstanceHolder<T>::SetInstance() to
> > directly set the concrete fake (and optional version). This simplifies
> > testing quite a bit.
> >
> > BUG=626695
> > TEST=trybots
> >
> > Committed: https://crrev.com/c5fffc64c14a0464f8870bbe91df7e945f42c3ca
> > Cr-Commit-Position: refs/heads/master@{#405138}
> 
> TBR=hidehiko@chromium.org,stevenjb@chromium.org,lhchavez@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=626695
> 
> Committed: https://crrev.com/03b1e37434a736bbb5c764dd980787e54c93868b
> Cr-Commit-Position: refs/heads/master@{#405165}
==========

[commit-bot: I haz the power, 2016-07-15 17:56:01]

Committed patchset #3 (id:270001)

[commit-bot: I haz the power, 2016-07-15 17:56:16]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-15 17:57:58]

Description was changed from

==========
Reland of arc: Use the new InstanceHolder for unittests (patchset #1 id:1 of
https://codereview.chromium.org/2146573005/ )

Reason for revert:
https://codereview.chromium.org/2150583002 should fix the underlying issue that
this change surfaced.

Original issue's description:
> Revert of arc: Use the new InstanceHolder for unittests (patchset #4 id:60001
of https://codereview.chromium.org/2138513002/ )
> 
> Reason for revert:
> Caused unit_tests failure on Linux ChromiumOS Tests (1):
> 
> ArcAppModelBuilderTest.RemoveAppCleanUpFolder
> 
> Original issue's description:
> > arc: Use the new InstanceHolder for unittests
> >
> > Instead of having unit tests go through Mojo and jump through hoops to
> > ensure that all messages have propagated to all the threads, we can use
> > the new arc::ArcBridgeService::InstanceHolder<T>::SetInstance() to
> > directly set the concrete fake (and optional version). This simplifies
> > testing quite a bit.
> >
> > BUG=626695
> > TEST=trybots
> >
> > Committed: https://crrev.com/c5fffc64c14a0464f8870bbe91df7e945f42c3ca
> > Cr-Commit-Position: refs/heads/master@{#405138}
> 
> TBR=hidehiko@chromium.org,stevenjb@chromium.org,lhchavez@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=626695
> 
> Committed: https://crrev.com/03b1e37434a736bbb5c764dd980787e54c93868b
> Cr-Commit-Position: refs/heads/master@{#405165}
==========

to

==========
Reland of arc: Use the new InstanceHolder for unittests (patchset #1 id:1 of
https://codereview.chromium.org/2146573005/ )

Reason for revert:
https://codereview.chromium.org/2150583002 should fix the underlying issue that
this change surfaced.

Original issue's description:
> Revert of arc: Use the new InstanceHolder for unittests (patchset #4 id:60001
of https://codereview.chromium.org/2138513002/ )
>
> Reason for revert:
> Caused unit_tests failure on Linux ChromiumOS Tests (1):
>
> ArcAppModelBuilderTest.RemoveAppCleanUpFolder
>
> Original issue's description:
> > arc: Use the new InstanceHolder for unittests
> >
> > Instead of having unit tests go through Mojo and jump through hoops to
> > ensure that all messages have propagated to all the threads, we can use
> > the new arc::ArcBridgeService::InstanceHolder<T>::SetInstance() to
> > directly set the concrete fake (and optional version). This simplifies
> > testing quite a bit.
> >
> > BUG=626695
> > TEST=trybots
> >
> > Committed: https://crrev.com/c5fffc64c14a0464f8870bbe91df7e945f42c3ca
> > Cr-Commit-Position: refs/heads/master@{#405138}
>
> TBR=hidehiko@chromium.org,stevenjb@chromium.org,lhchavez@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=626695
>
> Committed: https://crrev.com/03b1e37434a736bbb5c764dd980787e54c93868b
> Cr-Commit-Position: refs/heads/master@{#405165}

Committed: https://crrev.com/5aa0d0ed4da47326e168783b8251d8fbf0c58add
Cr-Commit-Position: refs/heads/master@{#405785}
==========

[commit-bot: I haz the power, 2016-07-15 17:58:01]

Patchset 3 (id:??) landed as
https://crrev.com/5aa0d0ed4da47326e168783b8251d8fbf0c58add
Cr-Commit-Position: refs/heads/master@{#405785}