Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2143983002: Fix context for fast accessors (lazy). (Closed)

Created:
4 years, 5 months ago by Alfonso
Modified:
4 years, 5 months ago
Reviewers:
Jarin, vogelheim
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix context for fast accessors (lazy). Fast accessors do not have an associated JSFunction, similar to lazy accessors. Now using the 'lazy' version of the CallApiCallbackStub. R=vogelheim@chromium.org BUG=chromium:508898 Committed: https://crrev.com/da4f2491501e54d436ed448c5e345480d1f5906b Cr-Commit-Position: refs/heads/master@{#37782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M src/code-stubs.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/fast-accessor-assembler.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Alfonso
4 years, 5 months ago (2016-07-13 13:30:16 UTC) #3
vogelheim
lgtm @jarin: Please OWNERS-review for crankshaft/*. The change in hydrogen.cc should be a no-op.
4 years, 5 months ago (2016-07-13 14:05:44 UTC) #7
Jarin
lgtm for crankshaft/*
4 years, 5 months ago (2016-07-14 20:05:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143983002/1
4 years, 5 months ago (2016-07-14 20:32:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 20:57:24 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 21:00:05 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da4f2491501e54d436ed448c5e345480d1f5906b
Cr-Commit-Position: refs/heads/master@{#37782}

Powered by Google App Engine
This is Rietveld 408576698