Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2143973005: [Layout API] Use layoutViewItem() in HTMLMediaElement (Closed)

Created:
4 years, 5 months ago by pilgrim_google
Modified:
4 years, 5 months ago
Reviewers:
eae, jsbell
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, vcarbune.chromium, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Use layoutViewItem() in HTMLMediaElement Document::layoutView() is deprecated and being removed soon. The replacement is Document::layoutViewItem(), which routes methods through the new block layout API. No new API methods were required. There are no functional changes. BUG=499321 Committed: https://crrev.com/7de2947e19575d5c2e45e22d5b064609ebc06c4d Cr-Commit-Position: refs/heads/master@{#405587}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
pilgrim_google
4 years, 5 months ago (2016-07-14 20:12:33 UTC) #2
eae
LGTM
4 years, 5 months ago (2016-07-14 21:48:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143973005/1
4 years, 5 months ago (2016-07-14 21:49:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 21:56:31 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 21:57:01 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 21:59:58 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7de2947e19575d5c2e45e22d5b064609ebc06c4d
Cr-Commit-Position: refs/heads/master@{#405587}

Powered by Google App Engine
This is Rietveld 408576698