Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2143973004: Use memory mapped file in courgette_tool (Closed)

Created:
4 years, 5 months ago by etiennep
Modified:
4 years, 5 months ago
Reviewers:
huangs, Will Harris
CC:
chromium-reviews, wfh+watch_chromium.org, huangs+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use memory mapped file in courgette_tool Patch generation and various utilities (disasm) now use memory mapped file instead of copying into a string buffer. This saves the equivalent of the size of both |old_file| and |new_file| in memory when generating the patch (~300Mb with chrome.7z). BUG= Committed: https://crrev.com/f4fe06cf053fd6679c49e79c2fda2f059f021898 Cr-Commit-Position: refs/heads/master@{#405599}

Patch Set 1 #

Patch Set 2 : Make BufferedFileReader const correct #

Total comments: 4

Patch Set 3 : Nit cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M courgette/courgette_tool.cc View 1 2 1 chunk +4 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
etiennep
This CL is the modification that brings MemoryMappedFile to courgette_tool. Samuel found out that using ...
4 years, 5 months ago (2016-07-14 17:50:02 UTC) #2
huangs
On 2016/07/14 17:50:02, etiennep wrote: > This CL is the modification that brings MemoryMappedFile to ...
4 years, 5 months ago (2016-07-14 18:48:19 UTC) #3
Will Harris
On 2016/07/14 18:48:19, huangs wrote: > On 2016/07/14 17:50:02, etiennep wrote: > > This CL ...
4 years, 5 months ago (2016-07-14 18:58:07 UTC) #4
huangs
Okay, then I'm fine with it as well. LGTM with NITs. https://chromiumcodereview.appspot.com/2143973004/diff/20001/courgette/courgette_tool.cc File courgette/courgette_tool.cc (right): ...
4 years, 5 months ago (2016-07-14 21:25:55 UTC) #5
etiennep
Great! https://chromiumcodereview.appspot.com/2143973004/diff/20001/courgette/courgette_tool.cc File courgette/courgette_tool.cc (right): https://chromiumcodereview.appspot.com/2143973004/diff/20001/courgette/courgette_tool.cc#newcode62 courgette/courgette_tool.cc:62: } On 2016/07/14 21:25:55, huangs wrote: > Can ...
4 years, 5 months ago (2016-07-14 21:32:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143973004/40001
4 years, 5 months ago (2016-07-14 21:34:48 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-14 22:16:16 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 22:17:55 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f4fe06cf053fd6679c49e79c2fda2f059f021898
Cr-Commit-Position: refs/heads/master@{#405599}

Powered by Google App Engine
This is Rietveld 408576698