Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: chrome/browser/ui/omnibox/chrome_omnibox_client.cc

Issue 2143953002: Remove search::ShouldPrefetchSearchResultsOnSRP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add TODO Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/search/search.cc ('k') | chrome/browser/ui/search/instant_extended_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/omnibox/chrome_omnibox_client.cc
diff --git a/chrome/browser/ui/omnibox/chrome_omnibox_client.cc b/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
index e534939f83ca69a5497232d7daf75a1f035d7180..0444a0ac5bd3ff56714ae59c535cecca4e6b015a 100644
--- a/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
+++ b/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
@@ -458,13 +458,11 @@ void ChromeOmniboxClient::SetSuggestionToPrefetch(
const InstantSuggestion& suggestion) {
DCHECK(search::IsInstantExtendedAPIEnabled());
content::WebContents* web_contents = controller_->GetWebContents();
- if (web_contents &&
- SearchTabHelper::FromWebContents(web_contents)->IsSearchResultsPage()) {
- if (search::ShouldPrefetchSearchResultsOnSRP()) {
- SearchTabHelper::FromWebContents(web_contents)->
- SetSuggestionToPrefetch(suggestion);
- }
- } else {
+ // TODO(treib): This check should probably be removed - IsSearchResultsPage
+ // will always return false here, because it'll only be true for pages
+ // rendered in the Instant process. crbug.com/627747
Marc Treib 2016/08/01 17:43:14 FYI: per our discussion on Friday, I added a TODO
Peter Kasting 2016/08/03 00:25:46 I'm OK with it either way, assuming it gets remove
+ if (!web_contents ||
+ !SearchTabHelper::FromWebContents(web_contents)->IsSearchResultsPage()) {
InstantSearchPrerenderer* prerenderer =
InstantSearchPrerenderer::GetForProfile(profile_);
if (prerenderer)
« no previous file with comments | « chrome/browser/search/search.cc ('k') | chrome/browser/ui/search/instant_extended_interactive_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698