Remove search::ShouldPrefetchSearchResultsOnSRP

chrome/browser/ui/omnibox/chrome_omnibox_client.cc

Index: chrome/browser/ui/omnibox/chrome_omnibox_client.cc
diff --git a/chrome/browser/ui/omnibox/chrome_omnibox_client.cc b/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
index e534939f83ca69a5497232d7daf75a1f035d7180..91d9bb206e82f56955bd953ddded2d31202ed79f 100644
--- a/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
+++ b/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
@@ -458,13 +458,8 @@ void ChromeOmniboxClient::SetSuggestionToPrefetch(
       const InstantSuggestion& suggestion) {
   DCHECK(search::IsInstantExtendedAPIEnabled());
   content::WebContents* web_contents = controller_->GetWebContents();
-  if (web_contents &&
-      SearchTabHelper::FromWebContents(web_contents)->IsSearchResultsPage()) {
-    if (search::ShouldPrefetchSearchResultsOnSRP()) {
-      SearchTabHelper::FromWebContents(web_contents)->
-          SetSuggestionToPrefetch(suggestion);
-    }
-  } else {
+  if (!web_contents ||
+      !SearchTabHelper::FromWebContents(web_contents)->IsSearchResultsPage()) {

[Marc Treib, 2016/07/29 10:40:14]

I've investigated a bit more, and it seems that IsSearchResultsPage() is always
false here in practice - it checks SearchMode.is_origin_search(), which is never
true:
If we started out on an NTP, it's origin_ntp instead.
If we started on a search page (or anywhere else), then that isn't rendered in
the Instant process, so it's considered to not have instant support, so it's
origin_default instead.

Is this expected? Was the whole special SRP handling abandoned, or is there a
bug somewhere?

     InstantSearchPrerenderer* prerenderer =
         InstantSearchPrerenderer::GetForProfile(profile_);
     if (prerenderer)