Chromium Code Reviews
Help | Chromium Project | Sign in
(2)

Issue 21439: Fix for focus traversal issue in Gears dialogs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by jcampan
Modified:
5 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com, munjal1
Visibility:
Public.

Description

HtmlDialogs had focus problems. They would not be focused when shown and tab traversal was not working. This was caused by several issues: - HWNDView was not focusing its HWND when focused through the View::RequestFocus() method (it would rely on the default view behavior which is to focus the root view HWND), so it would not be focused by default. - DOMView (parent of HtmlDialogView) was not focusable so would not get the focus when pressing tab. - DOMView was not eating tab keys events (by returning false in View::CanProcessTabKeyEvents()), so the render view would not get the tab key press messages (for focus traversal in the render view). Note: most of the file changes in this CL are just the consequence of changing the constness of the WindowDelegate::GetInitiallyFocusedView method. BUG=6859 TEST=Open a web page, from the page menu, select the "Create application shortcut..." menu. In the dialog, press the TAB key, focus should alternate between the different fields Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9925

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -16 lines) Patch
M chrome/browser/jsmessage_box_handler_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/jsmessage_box_handler_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/dom_view.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/views/dom_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/frame/browser_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/html_dialog_view.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/views/html_dialog_view.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/views/new_profile_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/new_profile_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/cookies_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/select_profile_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/select_profile_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/dialog_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/dialog_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/hwnd_view.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/views/hwnd_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/views/window_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 2 (0 generated)
jcampan
8 years ago (2009-02-18 00:24:35 UTC) #1
sky
8 years ago (2009-02-18 00:42:48 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f8e48bd