Reland "Don't compile functions in a context the caller doesn't have access to"

Reland "Don't compile functions in a context the caller doesn't have access to"

Original issue's description:
> Don't compile functions in a context the caller doesn't have access to
>
> Instead just return undefined
>
> A side effect of this is that it's no longer possible to compile
> functions in a detached context.
>
> BUG=chromium:541703
> R=verwaest@chromium.org,bmeurer@chromium.org

BUG=chromium:541703
R=verwaest@chromium.org

Committed: https://crrev.com/6bceabac5b705b2ce1f52d34650cea1ae3b8c617
Cr-Commit-Position: refs/heads/master@{#37756}

[jochen (gone - plz use gerrit), 2016-07-14 09:19:26]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 09:19:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-07-14 09:19:42]

jochen@chromium.org changed reviewers:
+ verwaest@chromium.org
- verwaest@chromiu.org

[jochen (gone - plz use gerrit), 2016-07-14 09:19:42]

ptal

[jochen (gone - plz use gerrit), 2016-07-14 09:19:49]

Description was changed from

==========
Reland "Don't compile functions in a context the caller doesn't have access to"

Original issue's description:
> Don't compile functions in a context the caller doesn't have access to
>
> Instead just return undefined
>
> A side effect of this is that it's no longer possible to compile
> functions in a detached context.
>
> BUG=chromium:541703
> R=verwaest@chromium.org,bmeurer@chromium.org

BUG=chromium:541703
R=verwaest@chromiu.org
==========

to

==========
Reland "Don't compile functions in a context the caller doesn't have access to"

Original issue's description:
> Don't compile functions in a context the caller doesn't have access to
>
> Instead just return undefined
>
> A side effect of this is that it's no longer possible to compile
> functions in a detached context.
>
> BUG=chromium:541703
> R=verwaest@chromium.org,bmeurer@chromium.org

BUG=chromium:541703
R=verwaest@chromium.org
==========

[jochen (gone - plz use gerrit), 2016-07-14 09:20:43]

note that d8 handily always enters a context before doing anything, while blink
doesn't enter a context for running microtasks

since there can be microtasks from several contexts in the queue, I think it
makes sense to always enter the task's context.

[jochen (gone - plz use gerrit), 2016-07-14 09:33:22]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 09:33:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 09:55:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 09:55:03]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-07-14 09:56:27]

lgtm

[jochen (gone - plz use gerrit), 2016-07-14 10:42:45]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 10:42:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-07-14 10:43:16]

added a check for entered context == target context for the case of blink code
running in a detached context - that should make the blink bot green I hope

[jochen (gone - plz use gerrit), 2016-07-14 11:05:38]

The CQ bit was unchecked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-07-14 11:05:41]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-07-14 11:05:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2143893005/#ps60001
(title: "updates")

[commit-bot: I haz the power, 2016-07-14 11:05:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 11:08:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-14 11:08:12]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 11:08:56]

Description was changed from

==========
Reland "Don't compile functions in a context the caller doesn't have access to"

Original issue's description:
> Don't compile functions in a context the caller doesn't have access to
>
> Instead just return undefined
>
> A side effect of this is that it's no longer possible to compile
> functions in a detached context.
>
> BUG=chromium:541703
> R=verwaest@chromium.org,bmeurer@chromium.org

BUG=chromium:541703
R=verwaest@chromium.org
==========

to

==========
Reland "Don't compile functions in a context the caller doesn't have access to"

Original issue's description:
> Don't compile functions in a context the caller doesn't have access to
>
> Instead just return undefined
>
> A side effect of this is that it's no longer possible to compile
> functions in a detached context.
>
> BUG=chromium:541703
> R=verwaest@chromium.org,bmeurer@chromium.org

BUG=chromium:541703
R=verwaest@chromium.org

Committed: https://crrev.com/6bceabac5b705b2ce1f52d34650cea1ae3b8c617
Cr-Commit-Position: refs/heads/master@{#37756}
==========

[commit-bot: I haz the power, 2016-07-14 11:08:57]

Patchset 4 (id:??) landed as
https://crrev.com/6bceabac5b705b2ce1f52d34650cea1ae3b8c617
Cr-Commit-Position: refs/heads/master@{#37756}

[jochen (gone - plz use gerrit), 2016-07-14 12:37:02]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2151843002/ by jochen@chromium.org.

The reason for reverting is: blink is unhappy about the microtask change.