Use vector assets for media router icons.

Use vector assets for media router icons.

Also fix a couple bugs in the vector icon views example read-from-disk path.

BUG=521199
TBR=oshima@chromium.org

Committed: https://crrev.com/f6206894a05d89ff73d943d2471cf1e476585e17
Cr-Commit-Position: refs/heads/master@{#405801}

[Evan Stade, 2016-07-13 18:12:22]

Description was changed from

==========
Use vector assets for media router icons.

BUG=624968
==========

to

==========
Use vector assets for media router icons.

BUG=521199
==========

[Evan Stade, 2016-07-13 18:12:23]

estade@chromium.org changed reviewers:
+ apacible@chromium.org

[Evan Stade, 2016-07-13 18:12:31]

how can I test this?

[Evan Stade, 2016-07-13 18:12:41]

On 2016/07/13 18:12:31, Evan Stade wrote:
> how can I test this?

(manually)

[Evan Stade, 2016-07-13 18:12:50]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 18:14:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 20:53:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 20:53:40]

Dry run: This issue passed the CQ dry run.

[apacible, 2016-07-13 22:30:19]

I'm having trouble with git cl patch to check it out locally, and don't have
time to manually copy paste at the moment... I assume the icons are the same
design/color, just in vector format? :)

If they're different, screenshots would be handy. Thanks!

https://codereview.chromium.org/2143863004/diff/1/chrome/app/theme/theme_reso...
File chrome/app/theme/theme_resources.grd (right):

https://codereview.chromium.org/2143863004/diff/1/chrome/app/theme/theme_reso...
chrome/app/theme/theme_resources.grd:729: <!-- Media Router -->
This line can also be removed.

https://codereview.chromium.org/2143863004/diff/1/chrome/browser/ui/toolbar/m...
File chrome/browser/ui/toolbar/media_router_action.cc (right):

https://codereview.chromium.org/2143863004/diff/1/chrome/browser/ui/toolbar/m...
chrome/browser/ui/toolbar/media_router_action.cc:24: #include
"ui/base/resource/resource_bundle.h"
Can we remove resource_bundle.h?

https://codereview.chromium.org/2143863004/diff/1/chrome/browser/ui/toolbar/m...
File chrome/browser/ui/toolbar/media_router_action_unittest.cc (right):

https://codereview.chromium.org/2143863004/diff/1/chrome/browser/ui/toolbar/m...
chrome/browser/ui/toolbar/media_router_action_unittest.cc:20: #include
"ui/base/resource/resource_bundle.h"
Same -- can we remove this?

[Evan Stade, 2016-07-14 17:41:28]

On 2016/07/13 22:30:19, apacible wrote:
> I'm having trouble with git cl patch to check it out locally, and don't have
> time to manually copy paste at the moment... I assume the icons are the same
> design/color, just in vector format? :)
> 
> If they're different, screenshots would be handy. Thanks!

I wish I could manually verify and produce screenshots, but I don't know how to
show this UI (see comment #4 above).

The new icons are pretty similar but not identical to the old ones. You can see
previews of them (in png format) on the linked bug.

[apacible, 2016-07-14 17:43:27]

On 2016/07/14 17:41:28, Evan Stade wrote:
> On 2016/07/13 22:30:19, apacible wrote:
> > I'm having trouble with git cl patch to check it out locally, and don't have
> > time to manually copy paste at the moment... I assume the icons are the same
> > design/color, just in vector format? :)
> > 
> > If they're different, screenshots would be handy. Thanks!
> 
> I wish I could manually verify and produce screenshots, but I don't know how
to
> show this UI (see comment #4 above).
> 
> The new icons are pretty similar but not identical to the old ones. You can
see
> previews of them (in png format) on the linked bug.

Ah, you can manually verify by  enabling Media Router (chrome://flags or
--enable-media-router) and installing the existing cast extension[1].

[1]
https://chrome.google.com/webstore/detail/google-cast/boadgeojelhgndaghljhdic...

[Evan Stade, 2016-07-14 19:16:22]

Description was changed from

==========
Use vector assets for media router icons.

BUG=521199
==========

to

==========
Use vector assets for media router icons.

Also fix a couple bugs in the vector icon views example read-from-disk path.

BUG=521199
==========

[Evan Stade, 2016-07-14 19:17:22]

On 2016/07/14 17:43:27, apacible wrote:
> On 2016/07/14 17:41:28, Evan Stade wrote:
> > On 2016/07/13 22:30:19, apacible wrote:
> > > I'm having trouble with git cl patch to check it out locally, and don't
have
> > > time to manually copy paste at the moment... I assume the icons are the
same
> > > design/color, just in vector format? :)
> > > 
> > > If they're different, screenshots would be handy. Thanks!
> > 
> > I wish I could manually verify and produce screenshots, but I don't know how
> to
> > show this UI (see comment #4 above).
> > 
> > The new icons are pretty similar but not identical to the old ones. You can
> see
> > previews of them (in png format) on the linked bug.
> 
> Ah, you can manually verify by  enabling Media Router (chrome://flags or
> --enable-media-router) and installing the existing cast extension[1].
> 
> [1]
>
https://chrome.google.com/webstore/detail/google-cast/boadgeojelhgndaghljhdic...

thanks, I verified it looks as expected for the idle icon. Don't know how to get
the other icons, but I checked that they were rendering correctly using
views_examples_with_content_exe.

[apacible, 2016-07-14 20:09:09]

Thanks! lgtm and rs lgtm for non-idle icons; I'll check it out (need to build
and load the component extension). :)

[Evan Stade, 2016-07-14 20:36:45]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-07-14 20:37:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-07-14 20:38:14]

estade@chromium.org changed reviewers:
+ msw@chromium.org, sadrul@chromium.org

[Evan Stade, 2016-07-14 20:38:15]

+sadrul for ui/views/examples/vector_example.cc
+msw for c/b/ui

[Evan Stade, 2016-07-14 20:38:21]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2016-07-14 20:38:27]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 20:39:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-07-14 20:57:02]

lgtm with a nit

https://codereview.chromium.org/2143863004/diff/40001/ui/gfx/paint_vector_ico...
File ui/gfx/paint_vector_icon.cc (right):

https://codereview.chromium.org/2143863004/diff/40001/ui/gfx/paint_vector_ico...
ui/gfx/paint_vector_icon.cc:70: int hex_value;
nit: init to 0; ditto above.

[commit-bot: I haz the power, 2016-07-14 22:16:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 22:16:54]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-07-15 14:24:36]

lgtm

[Evan Stade, 2016-07-15 17:37:32]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-07-15 17:37:33]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2016-07-15 17:39:05]

Description was changed from

==========
Use vector assets for media router icons.

Also fix a couple bugs in the vector icon views example read-from-disk path.

BUG=521199
==========

to

==========
Use vector assets for media router icons.

Also fix a couple bugs in the vector icon views example read-from-disk path.

BUG=521199
TBR=oshima@chromium.org
==========

[Evan Stade, 2016-07-15 17:39:05]

estade@chromium.org changed reviewers:
+ oshima@chromium.org

[Evan Stade, 2016-07-15 17:39:29]

+oshima TBR for chrome/app/theme/ deletions

[Evan Stade, 2016-07-15 17:39:46]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-07-15 17:39:46]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
apacible@chromium.org, msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2143863004/#ps60001
(title: "init to zero")

[commit-bot: I haz the power, 2016-07-15 17:40:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 18:42:35]

Description was changed from

==========
Use vector assets for media router icons.

Also fix a couple bugs in the vector icon views example read-from-disk path.

BUG=521199
TBR=oshima@chromium.org
==========

to

==========
Use vector assets for media router icons.

Also fix a couple bugs in the vector icon views example read-from-disk path.

BUG=521199
TBR=oshima@chromium.org
==========

[commit-bot: I haz the power, 2016-07-15 18:42:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-15 18:42:49]

CQ bit was unchecked.

[oshima, 2016-07-15 18:44:31]

c/a/t lgtm

[commit-bot: I haz the power, 2016-07-15 18:45:34]

Description was changed from

==========
Use vector assets for media router icons.

Also fix a couple bugs in the vector icon views example read-from-disk path.

BUG=521199
TBR=oshima@chromium.org
==========

to

==========
Use vector assets for media router icons.

Also fix a couple bugs in the vector icon views example read-from-disk path.

BUG=521199
TBR=oshima@chromium.org

Committed: https://crrev.com/f6206894a05d89ff73d943d2471cf1e476585e17
Cr-Commit-Position: refs/heads/master@{#405801}
==========

[commit-bot: I haz the power, 2016-07-15 18:45:36]

Patchset 4 (id:??) landed as
https://crrev.com/f6206894a05d89ff73d943d2471cf1e476585e17
Cr-Commit-Position: refs/heads/master@{#405801}