Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2143833003: [Match Spec] Form element pointer should not be updated w/in <template> (Closed)

Created:
4 years, 5 months ago by kouhei (in TOK)
Modified:
4 years, 5 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Match Spec] Form element pointer should not be updated w/in <template> This CL updates Blink HTML Parser to better match the spec. re: http://html5.org/tools/web-apps-tracker?from=8330&to=8331 The LayoutTest is based on WebKit change by rniwa@webkit.org: https://trac.webkit.org/changeset/160182 Bonus: - HTMLConstructionSite::setForm is merged into initFragmentParsing BUG=326058 Committed: https://crrev.com/8c33eb043f0c585eaea4629e360a257bb534d336 Cr-Commit-Position: refs/heads/master@{#405065}

Patch Set 1 #

Patch Set 2 : undo labels which have been split into separate CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -27 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/HTMLTemplateElement/no-form-association2.html View 1 chunk +39 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp View 5 chunks +14 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp View 7 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kouhei (in TOK)
4 years, 5 months ago (2016-07-13 05:48:28 UTC) #2
hayato
lgtm
4 years, 5 months ago (2016-07-13 06:14:03 UTC) #3
dominicc (has gone to gerrit)
lgtm Splendid.
4 years, 5 months ago (2016-07-13 06:15:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143833003/20001
4 years, 5 months ago (2016-07-13 06:16:09 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 07:13:13 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 07:13:21 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 07:14:55 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c33eb043f0c585eaea4629e360a257bb534d336
Cr-Commit-Position: refs/heads/master@{#405065}

Powered by Google App Engine
This is Rietveld 408576698