Rework MediaQueryMatcher to batch up listener notification

Rework MediaQueryMatcher to batch up listener notification

MediaQueryMatcher currently runs script synchronously inside layout and
recalc style which is bad. Instead we should collect all the listeners
that have changed and notify them asynchronously. Incidentally this is
what the spec says to do too, and also what Firefox and the polyfills
do.

This is the first step where we collect all the listeners that changed
in a Vector and then notify them as a group. This also fixes our behavior
where adding a listener in the middle of notification would get that one
called too, which is not what the spec says.

This also changes the notification order such that listeners are notified
in groups based on the creation time of their MediaQueryList which also
matches Firefox (and the polyfill) instead of in the order of global
calls to addListener.

[esprehn, 2014-04-03 21:42:33]

It occurred to me after I made this patch that we only have _two_ tests for
addListener/removeListener and one of them is a crash test and the other is for
checking what happens when an exception throws inside the listener....

so I think I need to add some tests first. I can also try to break this up into
more parts, but I figured I'd post the patch since eseidel had expressed
questions about where I was going.

[kenneth.r.christiansen, 2014-04-03 21:54:14]

https://codereview.chromium.org/214383008/diff/1/Source/core/css/MediaQueryMa...
File Source/core/css/MediaQueryMatcher.cpp (right):

https://codereview.chromium.org/214383008/diff/1/Source/core/css/MediaQueryMa...
Source/core/css/MediaQueryMatcher.cpp:134: (*it)->mediaChanged(toNotify);
couldn't the name be made more clear to what happens to toNotify? it also only
does something is updateMatches.

https://codereview.chromium.org/214383008/diff/1/Source/core/dom/Document.cpp
File Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/214383008/diff/1/Source/core/dom/Document.cpp...
Source/core/dom/Document.cpp:3328: m_mediaQueryMatcher->mediaChanged();
handleMediaChanged? actually I consider media to mean the media type and not the
whole query, which can contain media features. I don't know if we can find a
better name which covers type and features.

handleMediaPropertiesChanged?

[eseidel, 2014-05-28 22:31:21]

Yoav is mr. MediaQueries these days.  Looks like this CL may be dead anyway. 
(if so, please close.)

[esprehn, 2014-05-28 23:43:52]

On 2014/05/28 22:31:21, eseidel wrote:
> Yoav is mr. MediaQueries these days.  Looks like this CL may be dead anyway. 
> (if so, please close.)

It's not dead, I just haven't gotten to it. It's the last thing running script
inside ::layout() and ::updateStyle().

[Yoav Weiss, 2014-06-08 19:39:10]

On 2014/05/28 23:43:52, esprehn wrote:
> On 2014/05/28 22:31:21, eseidel wrote:
> > Yoav is mr. MediaQueries these days.  Looks like this CL may be dead anyway.

> > (if so, please close.)
> 
> It's not dead, I just haven't gotten to it. It's the last thing running script
> inside ::layout() and ::updateStyle().

As mentioned on #blink, the Opera test suite at
https://github.com/operasoftware/presto-testo/blob/master/core/standards/css3...
might be helpful here.
Also - the spec have recently changed to use MediaQueryListEvent rather than
MediaQueryListListener.

[rune, 2014-06-09 20:47:39]

On 2014/06/08 19:39:10, Yoav Weiss wrote:
> As mentioned on #blink, the Opera test suite at
> might be helpful here.
>
https://github.com/operasoftware/presto-testo/blob/master/core/standards/css3...

Don't trust that to match the spec anymore. I wrote it when I implemented it in
Presto some years ago.

[rune, 2014-06-10 06:17:07]

https://codereview.chromium.org/214383008/diff/1/Source/core/dom/Document.cpp
File Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/214383008/diff/1/Source/core/dom/Document.cpp...
Source/core/dom/Document.cpp:3328: m_mediaQueryMatcher->mediaChanged();
On 2014/04/03 21:54:15, kenneth.r.christiansen wrote:
> handleMediaChanged? actually I consider media to mean the media type and not
the
> whole query, which can contain media features. I don't know if we can find a
> better name which covers type and features.
> 
> handleMediaPropertiesChanged?

I was just looking at this in a different context. I thought about naming it
mediaFeaturesChanged().

[kenneth.r.christiansen, 2014-06-17 12:19:40]

Are you moving forward with this patch?

[esprehn, 2014-06-18 05:53:16]

On 2014/06/17 at 12:19:40, kenneth.r.christiansen wrote:
> Are you moving forward with this patch?

I'd like to, but I've been pulled away on a number of projects recently. It'd be
great if someone else could finish this up. We really need to get rid of this
round changeRound stuff and also stop running script inside updateRenderTree.

[cbiesinger, 2014-06-26 04:05:13]

I took over this CL and uploaded a new version to
https://codereview.chromium.org/348893004