content/browser/service_worker/service_worker_version.h - Issue 214383005: Browser side of ServiceWorker requestSyncEvents() function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 214383005: Browser side of ServiceWorker requestSyncEvents() function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleaned up the testing code Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_browsertest.cc ('k') | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.h

diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h

index 37670178acf8c7c0f205a7ffe3a1005098b77c90..568ce09d7a5bf62fb13ca2f5d2f6a344c836ae68 100644

--- a/content/browser/service_worker/service_worker_version.h

+++ b/content/browser/service_worker/service_worker_version.h

@@ -163,6 +163,9 @@ class CONTENT_EXPORT ServiceWorkerVersion

void AddProcessToWorker(int process_id);

void RemoveProcessToWorker(int process_id);

+ // Allows registering for sync events.

+ void RequestSyncEvents(bool requested);

michaeln 2014/04/05 01:54:47 maybe a getter too

EmbeddedWorkerInstance* embedded_worker() { return embedded_worker_.get(); }

// EmbeddedWorkerInstance::Observer overrides:

@@ -182,6 +185,9 @@ class CONTENT_EXPORT ServiceWorkerVersion

Status status_;

bool is_shutdown_;

+ // TODO(jkarlin): requested_sync_events_ needs to persist across Chrome

+ // restarts once SWs start to have such persistence.

+ bool requested_sync_events_;

scoped_refptr<ServiceWorkerRegistration> registration_;

scoped_ptr<EmbeddedWorkerInstance> embedded_worker_;