Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2143823002: MD Settings: Bluetooth: Show policy indicator when disabled by policy (Closed)

Created:
4 years, 5 months ago by stevenjb
Modified:
4 years, 5 months ago
Reviewers:
Ivan Šandrk, Dan Beam
CC:
chromium-reviews, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@issue_602538_bluetooth_fixes_1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Bluetooth: Show policy indicator when disabled by policy BUG=612846 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/4ca26c822f43596dbae31d180504075b147ff600 Cr-Commit-Position: refs/heads/master@{#406662}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M chrome/browser/chromeos/settings/stub_cros_settings_provider.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/settings_private/prefs_util.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/advanced_page/advanced_page.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (12 generated)
stevenjb
4 years, 5 months ago (2016-07-12 23:29:04 UTC) #3
Dan Beam
lgtm
4 years, 5 months ago (2016-07-13 01:29:50 UTC) #4
Ivan Šandrk
lgtm
4 years, 5 months ago (2016-07-13 12:04:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143823002/1
4 years, 5 months ago (2016-07-18 15:46:50 UTC) #7
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-18 15:46:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/37111) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-18 15:49:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143823002/20001
4 years, 5 months ago (2016-07-18 21:09:52 UTC) #14
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-18 21:09:53 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/245968)
4 years, 5 months ago (2016-07-18 22:28:00 UTC) #17
stevenjb
4 years, 5 months ago (2016-07-20 19:56:26 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143823002/60001
4 years, 5 months ago (2016-07-20 19:57:04 UTC) #22
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-20 19:57:06 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 5 months ago (2016-07-20 20:51:02 UTC) #24
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 20:54:02 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4ca26c822f43596dbae31d180504075b147ff600
Cr-Commit-Position: refs/heads/master@{#406662}

Powered by Google App Engine
This is Rietveld 408576698