Preventing touch events from registering when they occur outside the desktop image

Preventing touch events from registering when they occur outside the desktop image

We now drop any tap or longpress touch events which occur outside the
image boundaries.  Trackpad mode is not affected as the cursor was
already constrained.

BUG=627334
Committed: https://crrev.com/2c3697c6003d9a89a17019ab5b72b2ca63349f90
Cr-Commit-Position: refs/heads/master@{#404884}

[joedow, 2016-07-12 23:07:03]

joedow@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[joedow, 2016-07-12 23:07:04]

PTAL!

[Lambros, 2016-07-12 23:19:50]

lgtm - suggestions are optional.

https://codereview.chromium.org/2143813002/diff/1/remoting/android/java/src/o...
File remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java
(right):

https://codereview.chromium.org/2143813002/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java:630:
private boolean mapScreenPointToImage(float screenX, float screenY) {
Looks like we have this logic a few times in this file already. Maybe have this
function take a mutable PointF object to accept the transformed coords? Doesn't
have to block this CL from landing.

https://codereview.chromium.org/2143813002/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java:642:
return (mappedPoints[0] >= 0 && mappedPoints[0] <= imageWidth)
Is it worth adding a little bit of slop margin here? If the user taps at the
extreme edge, it might be a bit frustrating for the tap to sometimes go through
and sometimes not?

[joedow, 2016-07-13 00:04:50]

Thanks!

https://codereview.chromium.org/2143813002/diff/1/remoting/android/java/src/o...
File remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java
(right):

https://codereview.chromium.org/2143813002/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java:630:
private boolean mapScreenPointToImage(float screenX, float screenY) {
On 2016/07/12 23:19:50, Lambros wrote:
> Looks like we have this logic a few times in this file already. Maybe have
this
> function take a mutable PointF object to accept the transformed coords?
Doesn't
> have to block this CL from landing.

Ack.  I was thinking this kind of functionality may make sense to move in
RenderData (if it continues to exist with the refactoring).  Leaving for this CL
but will consider it in a future CL.

https://codereview.chromium.org/2143813002/diff/1/remoting/android/java/src/o...
remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java:642:
return (mappedPoints[0] >= 0 && mappedPoints[0] <= imageWidth)
On 2016/07/12 23:19:50, Lambros wrote:
> Is it worth adding a little bit of slop margin here? If the user taps at the
> extreme edge, it might be a bit frustrating for the tap to sometimes go
through
> and sometimes not?

I considered that, but this method is only used when the display is sufficiently
shrunk that the desktop image has a border.  If they are having difficulty
tapping an edge target (or any target really), I'd think it would be more
reliable for them to zoom in a bit.

[joedow, 2016-07-13 00:04:54]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-07-13 00:07:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 01:43:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-13 01:46:56]

Description was changed from

==========
Preventing touch events from registering when they occur outside the desktop
image

We now drop any tap or longpress touch events which occur outside the
image boundaries.  Trackpad mode is not affected as the cursor was
already constrained.

BUG=627334
==========

to

==========
Preventing touch events from registering when they occur outside the desktop
image

We now drop any tap or longpress touch events which occur outside the
image boundaries.  Trackpad mode is not affected as the cursor was
already constrained.

BUG=627334

Committed: https://crrev.com/2c3697c6003d9a89a17019ab5b72b2ca63349f90
Cr-Commit-Position: refs/heads/master@{#404884}
==========

[commit-bot: I haz the power, 2016-07-13 01:46:57]

Patchset 1 (id:??) landed as
https://crrev.com/2c3697c6003d9a89a17019ab5b72b2ca63349f90
Cr-Commit-Position: refs/heads/master@{#404884}