Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2313)

Unified Diff: chrome/browser/resources/settings/controls/settings_dropdown_menu.html

Issue 2143733002: MD Settings: settings-dropdown-menu, restore "Enter" key behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/controls/settings_dropdown_menu.html
diff --git a/chrome/browser/resources/settings/controls/settings_dropdown_menu.html b/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
index 89654d12163039c555dfccf322e13019838bcfb1..3e9e3e5ef8ca8240d442b435b4dddb63be9a14fb 100644
--- a/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
+++ b/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
@@ -16,17 +16,16 @@
<paper-listbox class="dropdown-content" selected="{{selected_}}"
attr-for-selected="data-value">
<template is="dom-repeat" items="[[menuOptions]]" initial-count="5">
- <!--TODO(dpapad): Use <button class="paper-item">..</button> once it
- lands in paper-item-shared-styles.html-->
dpapad 2016/07/12 23:18:02 Removed this TODO, since based on Michael's latest
- <div class="dropdown-item" role="option" data-value$="[[item.value]]">
+ <button class="dropdown-item" role="option"
+ data-value$="[[item.value]]">
[[item.name]]
- </div>
+ </button>
</template>
- <div class="dropdown-item" role="option"
+ <button class="dropdown-item" role="option"
data-value$="[[notFoundValue_]]"
hidden$="[[!isSelectedNotFound_(selected_)]]">
$i18n{custom}
- </div>
+ </button>
</paper-listbox>
</paper-dropdown-menu>
</template>

Powered by Google App Engine
This is Rietveld 408576698