Chromium Code Reviews| Index: chrome/browser/resources/settings/controls/settings_dropdown_menu.html |
| diff --git a/chrome/browser/resources/settings/controls/settings_dropdown_menu.html b/chrome/browser/resources/settings/controls/settings_dropdown_menu.html |
| index 89654d12163039c555dfccf322e13019838bcfb1..3e9e3e5ef8ca8240d442b435b4dddb63be9a14fb 100644 |
| --- a/chrome/browser/resources/settings/controls/settings_dropdown_menu.html |
| +++ b/chrome/browser/resources/settings/controls/settings_dropdown_menu.html |
| @@ -16,17 +16,16 @@ |
| <paper-listbox class="dropdown-content" selected="{{selected_}}" |
| attr-for-selected="data-value"> |
| <template is="dom-repeat" items="[[menuOptions]]" initial-count="5"> |
| - <!--TODO(dpapad): Use <button class="paper-item">..</button> once it |
| - lands in paper-item-shared-styles.html--> |
|
dpapad
2016/07/12 23:18:02
Removed this TODO, since based on Michael's latest
|
| - <div class="dropdown-item" role="option" data-value$="[[item.value]]"> |
| + <button class="dropdown-item" role="option" |
| + data-value$="[[item.value]]"> |
| [[item.name]] |
| - </div> |
| + </button> |
| </template> |
| - <div class="dropdown-item" role="option" |
| + <button class="dropdown-item" role="option" |
| data-value$="[[notFoundValue_]]" |
| hidden$="[[!isSelectedNotFound_(selected_)]]"> |
| $i18n{custom} |
| - </div> |
| + </button> |
| </paper-listbox> |
| </paper-dropdown-menu> |
| </template> |