chrome/browser/resources/settings/settings_shared_css.html - Issue 2143733002: MD Settings: settings-dropdown-menu, restore "Enter" key behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_shared_css.html

Issue 2143733002: MD Settings: settings-dropdown-menu, restore "Enter" key behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/controls/settings_dropdown_menu.html ('K') | « chrome/browser/resources/settings/controls/settings_dropdown_menu.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_shared_css.html

diff --git a/chrome/browser/resources/settings/settings_shared_css.html b/chrome/browser/resources/settings/settings_shared_css.html

index a04010cd17536ac42079476780000fd5e90f8298..2e8451e154f27ecd3a6a2744c13ff2ef8006703c 100644

--- a/chrome/browser/resources/settings/settings_shared_css.html

+++ b/chrome/browser/resources/settings/settings_shared_css.html

@@ -39,11 +39,14 @@

paper-dropdown-menu .dropdown-item {

align-items: center;

+ background: none;

+ border: none;

Dan Beam 2016/07/12 23:00:27 nit: -webkit-appearance: none;

dpapad 2016/07/12 23:18:02 Does not seem to work equivalently for me, see htt

Dan Beam 2016/07/12 23:27:26 we use it in widgets.css and otherwise a -webkit-a

color: var(--paper-grey-800);

display: flex;

font-size: inherit;

Dan Beam 2016/07/12 23:00:27 do we need to change this to font: inherit? i rem

dpapad 2016/07/12 23:18:02 Done. Changing 'font-size' to 'font' indeed has an

min-height: 48px;

padding: 0 16px;

+ width: 100%;

}

paper-dropdown-menu .dropdown-item.iron-selected {