Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2143653007: Remove icon bg color for message center notifications. (Closed)

Created:
4 years, 5 months ago by Evan Stade
Modified:
4 years, 5 months ago
CC:
chromium-reviews, asanka, Peter Beverloo, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove icon bg color for message center notifications. Also change notification bg from 0xFEFEFE to 0xFFFFFF BUG=624968 TBR=rdsmith@chromium.org Committed: https://crrev.com/5f03e0573aea8073bfe1751d1208deb696a923b5 Cr-Commit-Position: refs/heads/master@{#405874}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -26 lines) Patch
M chrome/browser/download/notification/download_item_notification.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/message_center/cocoa/notification_controller.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/message_center/message_center_style.h View 1 chunk +1 line, -3 lines 0 comments Download
M ui/message_center/notification.h View 2 chunks +0 lines, -9 lines 0 comments Download
M ui/message_center/notification.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M ui/message_center/views/notification_view.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Evan Stade
4 years, 5 months ago (2016-07-13 16:40:16 UTC) #2
stevenjb
lgtm
4 years, 5 months ago (2016-07-13 16:44:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143653007/1
4 years, 5 months ago (2016-07-13 16:48:25 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/217310)
4 years, 5 months ago (2016-07-13 16:57:24 UTC) #10
Evan Stade
tbr rdsmith for minor change in download_item_notification.cc
4 years, 5 months ago (2016-07-15 19:31:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143653007/1
4 years, 5 months ago (2016-07-15 19:32:38 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 22:04:52 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 22:05:05 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 22:08:29 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f03e0573aea8073bfe1751d1208deb696a923b5
Cr-Commit-Position: refs/heads/master@{#405874}

Powered by Google App Engine
This is Rietveld 408576698