Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 214363002: drive: Return cancel closure from FileSystem::GetFileContent (Closed)

Created:
6 years, 9 months ago by hashimoto
Modified:
6 years, 9 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, tfarina, nhiroki, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Return cancel closure from FileSystem::GetFileContent This change does not fix the bug, just a preparation for the actual fix. No behavior change is intended. Return cancel closure from DownloadOperation and FileSystem. Change user code (SyncClient and DriveFileStreamReader) to use the returned closure. BUG=344789 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260184

Patch Set 1 : #

Total comments: 3

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -131 lines) Patch
M chrome/browser/chromeos/drive/drive_file_stream_reader.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_stream_reader.cc View 1 9 chunks +26 lines, -23 lines 0 comments Download
M chrome/browser/chromeos/drive/dummy_file_system.h View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/browser/chromeos/drive/dummy_file_system.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/fake_file_system.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/fake_file_system.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/fake_file_system_unittest.cc View 4 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.cc View 7 chunks +25 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation_unittest.cc View 3 chunks +10 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_interface.h View 3 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client.h View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client.cc View 5 chunks +16 lines, -27 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/drive/task_util.h View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hashimoto
https://codereview.chromium.org/214363002/diff/100001/chrome/browser/chromeos/drive/file_system_interface.h File chrome/browser/chromeos/drive/file_system_interface.h (right): https://codereview.chromium.org/214363002/diff/100001/chrome/browser/chromeos/drive/file_system_interface.h#newcode78 chrome/browser/chromeos/drive/file_system_interface.h:78: scoped_ptr<ResourceEntry> entry)> |entry| and |local_file| are swapped to use ...
6 years, 9 months ago (2014-03-27 08:27:48 UTC) #1
kinaba
lgtm https://codereview.chromium.org/214363002/diff/100001/chrome/browser/chromeos/drive/drive_file_stream_reader.cc File chrome/browser/chromeos/drive/drive_file_stream_reader.cc (right): https://codereview.chromium.org/214363002/diff/100001/chrome/browser/chromeos/drive/drive_file_stream_reader.cc#newcode378 chrome/browser/chromeos/drive/drive_file_stream_reader.cc:378: DCHECK(!cancel_download_closure_.is_null()); nit: Could you add some short comment ...
6 years, 9 months ago (2014-03-28 08:25:43 UTC) #2
hashimoto
https://codereview.chromium.org/214363002/diff/100001/chrome/browser/chromeos/drive/drive_file_stream_reader.cc File chrome/browser/chromeos/drive/drive_file_stream_reader.cc (right): https://codereview.chromium.org/214363002/diff/100001/chrome/browser/chromeos/drive/drive_file_stream_reader.cc#newcode378 chrome/browser/chromeos/drive/drive_file_stream_reader.cc:378: DCHECK(!cancel_download_closure_.is_null()); On 2014/03/28 08:25:43, kinaba wrote: > nit: Could ...
6 years, 9 months ago (2014-03-28 09:34:20 UTC) #3
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 9 months ago (2014-03-28 09:34:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/214363002/120001
6 years, 9 months ago (2014-03-28 09:36:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 11:15:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-28 11:15:55 UTC) #7
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 9 months ago (2014-03-28 15:03:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/214363002/120001
6 years, 9 months ago (2014-03-28 15:06:24 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 17:22:25 UTC) #10
Message was sent while issue was closed. 
Change committed as 260184

Powered by Google App Engine
This is Rietveld 408576698