Add new tests to the Notification Mac Bridge

chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <AppKit/AppKit.h>
 
 #include "base/mac/scoped_nsobject.h"
 #include "chrome/browser/notifications/notification.h"
 #include "chrome/browser/notifications/notification_platform_bridge_mac.h"
 #include "chrome/browser/notifications/notification_test_util.h"
@@ skipping 114 matching lines @@
   NotificationPlatformBridgeMac* bridge = new NotificationPlatformBridgeMac(
       notificationCenter, false /* set_delegate */);
   [[notificationCenter expect]
       deliverNotification:[OCMArg checkWithBlock:^BOOL(id toast) {
         return [[toast title] isEqualToString:@"Title"] &&
                [[toast informativeText] isEqualToString:@"Context"] &&
                [[toast subtitle] isEqualToString:@"https://gmail.com"] &&
                [[toast actionButtonTitle] isEqualToString:@"Settings"] &&
                [[toast otherButtonTitle] isEqualToString:@"Close"];
       }]];
-  bridge->Display(NotificationCommon::PERSISTENT,
-      "notification_id", "profile_id", false, *notification);
+  bridge->Display(NotificationCommon::PERSISTENT, "notification_id",
+                  "profile_id", false, *notification);
   [notificationCenter verify];
 }
 
 TEST_F(NotificationPlatformBridgeMacTest, TestDisplayOneButton) {
   std::unique_ptr<Notification> notification =
       NotificationGenerator::CreateNotification(
           "Title", "Context", "https://gmail.com", "Button 1", "",
           message_center::NOTIFICATION_TYPE_SIMPLE);
 
   id notificationCenter =
       [OCMockObject mockForClass:[NSUserNotificationCenter class]];
   NotificationPlatformBridgeMac* bridge = new NotificationPlatformBridgeMac(
       notificationCenter, false /* set_delegate */);
   [[notificationCenter expect]
       deliverNotification:[OCMArg checkWithBlock:^BOOL(id toast) {
         return [[toast title] isEqualToString:@"Title"] &&
                [[toast informativeText] isEqualToString:@"Context"] &&
                [[toast subtitle] isEqualToString:@"https://gmail.com"] &&
                [[toast actionButtonTitle] isEqualToString:@"Options"] &&
                [[toast otherButtonTitle] isEqualToString:@"Close"];
       }]];
-  bridge->Display(NotificationCommon::PERSISTENT,
-      "notification_id", "profile_id", false, *notification);
+  bridge->Display(NotificationCommon::PERSISTENT, "notification_id",
+                  "profile_id", false, *notification);
   [notificationCenter verify];
 }
+
+// FAILURE: Uses a nice mock instead of a mock which *should* not
+// not care about uncalled methods.
+// Crashes with : *** -[NSProxy doesNotRecognizeSelector:setDelegate:] called!
+TEST_F(NotificationPlatformBridgeMacTest, TestDisplayNiceMock) {
+  std::unique_ptr<Notification> notification =
+      NotificationGenerator::CreateNotification(
+          "Title", "Context", "https://gmail.com", "Button 1", "",
+          message_center::NOTIFICATION_TYPE_SIMPLE);
+
+  id notificationCenter =
+      [OCMockObject niceMockForClass:[NSUserNotificationCenter class]];
+  NotificationPlatformBridgeMac* bridge =
+      new NotificationPlatformBridgeMac(notificationCenter);
+  [[notificationCenter expect]
+      deliverNotification:[OCMArg checkWithBlock:^BOOL(id toast) {
+        return [[toast title] isEqualToString:@"Title"] &&
+               [[toast informativeText] isEqualToString:@"Context"] &&
+               [[toast subtitle] isEqualToString:@"https://gmail.com"] &&
+               [[toast actionButtonTitle] isEqualToString:@"Options"] &&
+               [[toast otherButtonTitle] isEqualToString:@"Close"];
+      }]];
+  bridge->Display(NotificationCommon::PERSISTENT, "notification_id",
+                  "profile_id", false, *notification);
+  [notificationCenter verify];
+}
+
+// Close: Set the property as if it was a method.
+// Fails with
+// [NSProxy doesNotRecognizeSelector:deliveredNotifications] called!
+TEST_F(NotificationPlatformBridgeMacTest, TestCloseOneWay) {
+  id notificationCenter =
+      [OCMockObject niceMockForClass:[NSUserNotificationCenter class]];
+  NotificationPlatformBridgeMac* bridge =
+      new NotificationPlatformBridgeMac(notificationCenter, false);
+  [[notificationCenter expect] deliveredNotifications];
+  bridge->Close("profile_id", "notification_id");
+  [notificationCenter verify];
+}
+
+// Close: Set the property as a key value pair in the documentation.
+// Fails with
+// [NSProxy doesNotRecognizeSelector:deliveredNotifications] called!
+TEST_F(NotificationPlatformBridgeMacTest, TestCloseAnotherWay) {
+  id notificationCenter =
+      [OCMockObject niceMockForClass:[NSUserNotificationCenter class]];
+  NotificationPlatformBridgeMac* bridge =
+      new NotificationPlatformBridgeMac(notificationCenter, false);
+  [[(id)notificationCenter expect] deliveredNotifications];
+  bridge->Close("profile_id", "notification_id");
+  [notificationCenter verify];
+}