[FRE] Only finish corresponding First Run Experience when exiting

Only finish corresponding First Run Experience when exiting

BUG=626999, 627444
Committed: https://crrev.com/f8c28f849c1229b24c222e008800b1b4d7a42682
Cr-Commit-Position: refs/heads/master@{#405542}

[gogerald1, 2016-07-12 17:10:42]

Description was changed from

==========
fix bug

BUG=
==========

to

==========
Launch the First Run Experience in single task

Relaunch the ongoing First Run Experience if another request is coming.

BUG=626999
==========

[gogerald1, 2016-07-12 17:11:25]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 17:12:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 18:14:03]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 18:14:04]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[gogerald1, 2016-07-12 19:40:03]

Patchset #1 (id:1) has been deleted

[gogerald1, 2016-07-12 19:42:39]

Description was changed from

==========
Launch the First Run Experience in single task

Relaunch the ongoing First Run Experience if another request is coming.

BUG=626999
==========

to

==========
Only finish correspond First Run Experience when exiting

BUG=626999
==========

[gogerald1, 2016-07-12 19:43:12]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 19:45:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-07-12 19:49:35]

Description was changed from

==========
Only finish correspond First Run Experience when exiting

BUG=626999
==========

to

==========
Only finish corresponding First Run Experience when exiting

BUG=626999
==========

[gogerald1, 2016-07-12 19:49:57]

gogerald@chromium.org changed reviewers:
+ bauerb@chromium.org

[gogerald1, 2016-07-12 19:49:58]

Hi, PTAL,

[commit-bot: I haz the power, 2016-07-12 20:43:43]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 20:43:44]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Bernhard Bauer, 2016-07-13 08:19:46]

https://codereview.chromium.org/2143583003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
(right):

https://codereview.chromium.org/2143583003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java:371:
protected static void finishAllFREActivities(int result, Intent data, String
targetActivity) {
This method doesn't really finish FRE activities anymore, it finishes all
activities of a certain class (defined by its name). So, update the method name
to remove "FRE", update the parameter name to make it clear it's a class name,
and maybe add Javadoc?

[gogerald1, 2016-07-13 22:42:42]

https://codereview.chromium.org/2143583003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
(right):

https://codereview.chromium.org/2143583003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java:371:
protected static void finishAllFREActivities(int result, Intent data, String
targetActivity) {
On 2016/07/13 08:19:46, Bernhard Bauer wrote:
> This method doesn't really finish FRE activities anymore, it finishes all
> activities of a certain class (defined by its name). So, update the method
name
> to remove "FRE", update the parameter name to make it clear it's a class name,
> and maybe add Javadoc?

Done.

[Bernhard Bauer, 2016-07-14 10:27:24]

lgtm

https://codereview.chromium.org/2143583003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
(right):

https://codereview.chromium.org/2143583003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java:372:
* Finish all the instances of the Activity.
Nit: "the given Activity"

[gogerald1, 2016-07-14 15:27:45]

https://codereview.chromium.org/2143583003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
(right):

https://codereview.chromium.org/2143583003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java:372:
* Finish all the instances of the Activity.
On 2016/07/14 10:27:24, Bernhard Bauer wrote:
> Nit: "the given Activity"

Done.

[gogerald1, 2016-07-14 15:27:49]

The CQ bit was checked by gogerald@chromium.org

[gogerald1, 2016-07-14 15:27:50]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2143583003/#ps60001
(title: "address nit")

[commit-bot: I haz the power, 2016-07-14 15:28:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 16:32:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 16:32:49]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[gogerald1, 2016-07-14 18:05:27]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 18:06:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-07-14 18:30:23]

Description was changed from

==========
Only finish corresponding First Run Experience when exiting

BUG=626999
==========

to

==========
Only finish corresponding First Run Experience when exiting

BUG=626999,627444
==========

[commit-bot: I haz the power, 2016-07-14 19:03:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 19:03:14]

Dry run: This issue passed the CQ dry run.

[gogerald1, 2016-07-14 19:28:59]

The CQ bit was checked by gogerald@chromium.org

[gogerald1, 2016-07-14 19:28:59]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2143583003/#ps80001
(title: "do null check")

[commit-bot: I haz the power, 2016-07-14 19:29:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 19:36:11]

Description was changed from

==========
Only finish corresponding First Run Experience when exiting

BUG=626999,627444
==========

to

==========
Only finish corresponding First Run Experience when exiting

BUG=626999,627444
==========

[commit-bot: I haz the power, 2016-07-14 19:36:12]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-07-14 19:36:15]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 19:38:05]

Description was changed from

==========
Only finish corresponding First Run Experience when exiting

BUG=626999,627444
==========

to

==========
Only finish corresponding First Run Experience when exiting

BUG=626999,627444

Committed: https://crrev.com/f8c28f849c1229b24c222e008800b1b4d7a42682
Cr-Commit-Position: refs/heads/master@{#405542}
==========

[commit-bot: I haz the power, 2016-07-14 19:38:06]

Patchset 4 (id:??) landed as
https://crrev.com/f8c28f849c1229b24c222e008800b1b4d7a42682
Cr-Commit-Position: refs/heads/master@{#405542}