Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issue 2143523002: mac: Add WebGL power test (Closed)

Created:
4 years, 5 months ago by erikchen
Modified:
4 years, 5 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp82
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Add WebGL power test The test is exceedingly simple. It uses requestAnimationFrame and WebGL APIs to animate the background color of the page. BUG=616811 Committed: https://crrev.com/ad659671899c8629433fc7904e109ab34f15eafd Cr-Commit-Position: refs/heads/master@{#405182}

Patch Set 1 #

Patch Set 2 : add file. #

Total comments: 2

Patch Set 3 : Comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M tools/perf/page_sets/mac_gpu_sites.py View 3 chunks +21 lines, -0 lines 0 comments Download
A + tools/perf/page_sets/trivial_sites/trivial_webgl.html View 1 2 1 chunk +5 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (9 generated)
erikchen
nednguyen: Please review.
4 years, 5 months ago (2016-07-12 01:59:17 UTC) #2
nednguyen
I defer reviewing this to Charlie
4 years, 5 months ago (2016-07-12 02:11:35 UTC) #6
charliea (OOO until 10-5)
lgtm w/ suggestion https://codereview.chromium.org/2143523002/diff/20001/tools/perf/page_sets/trivial_sites/trivial_webgl.html File tools/perf/page_sets/trivial_sites/trivial_webgl.html (right): https://codereview.chromium.org/2143523002/diff/20001/tools/perf/page_sets/trivial_sites/trivial_webgl.html#newcode30 tools/perf/page_sets/trivial_sites/trivial_webgl.html:30: rColor += 1; nit: maybe rColor ...
4 years, 5 months ago (2016-07-12 15:30:09 UTC) #9
nednguyen
owner stamp lgtm
4 years, 5 months ago (2016-07-12 15:34:29 UTC) #10
erikchen
https://codereview.chromium.org/2143523002/diff/20001/tools/perf/page_sets/trivial_sites/trivial_webgl.html File tools/perf/page_sets/trivial_sites/trivial_webgl.html (right): https://codereview.chromium.org/2143523002/diff/20001/tools/perf/page_sets/trivial_sites/trivial_webgl.html#newcode30 tools/perf/page_sets/trivial_sites/trivial_webgl.html:30: rColor += 1; On 2016/07/12 15:30:09, charliea wrote: > ...
4 years, 5 months ago (2016-07-12 18:08:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143523002/40001
4 years, 5 months ago (2016-07-13 15:29:07 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-13 16:26:56 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 16:28:40 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ad659671899c8629433fc7904e109ab34f15eafd
Cr-Commit-Position: refs/heads/master@{#405182}

Powered by Google App Engine
This is Rietveld 408576698