Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2143483003: Delete test that is already being tested in w3c test suite (Closed)

Created:
4 years, 5 months ago by nainar
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete test that is already being tested in w3c test suite Delete the test as already being tested here: https://github.com/w3c/web-platform-tests/blob/master/web-animations/interfaces/Animatable/animate.html BUG=623437 Committed: https://crrev.com/565db0d042d2cbc46b04094caf773f210d4d38b0 Cr-Commit-Position: refs/heads/master@{#404768}

Patch Set 1 #

Patch Set 2 : add title #

Patch Set 3 : Delete test #

Patch Set 4 : add necessary headers #

Patch Set 5 : Delete test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
D third_party/WebKit/LayoutTests/web-animations-api/animation-id.html View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
nainar
Hi Suzy, It seemed like this test was granular enough and just needed a name ...
4 years, 5 months ago (2016-07-12 00:07:36 UTC) #3
nainar
Sending back. Deleted test as per discussion with Alan IRL
4 years, 5 months ago (2016-07-12 00:24:29 UTC) #5
suzyh_UTC10 (ex-contributor)
lgtm
4 years, 5 months ago (2016-07-12 00:30:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143483003/40001
4 years, 5 months ago (2016-07-12 00:35:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143483003/80001
4 years, 5 months ago (2016-07-12 00:50:56 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-07-12 02:29:36 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 02:30:03 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 02:31:07 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/565db0d042d2cbc46b04094caf773f210d4d38b0
Cr-Commit-Position: refs/heads/master@{#404768}

Powered by Google App Engine
This is Rietveld 408576698