[ash-md] Updates window title if it is changed after entering overview

[ash-md] Updates window title if it is changed after entering overview

Need to call LabelButton::Layout since this requires updated preferred
width of the label and that needs up to date text.

BUG=624612
Committed: https://crrev.com/2bd9e5c30da7d762dfeac6dd2eee88aea9603f6e
Cr-Commit-Position: refs/heads/master@{#405083}

[varkha, 2016-07-11 22:14:27]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 22:15:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2016-07-11 22:58:36]

Patchset #2 (id:20001) has been deleted

[varkha, 2016-07-11 23:01:39]

varkha@chromium.org changed reviewers:
+ sadrul@chromium.org

[varkha, 2016-07-11 23:01:39]

sadrul@, I think the LabelButton should update layout automagically when
SetText() is called (PS2). WDYT? If not it is easy to just call Layout from the
call site (as in PS1), but I think updated layout is expected here. can you
please take a look, thanks!

[varkha, 2016-07-11 23:01:54]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 23:03:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 01:07:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 01:07:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2016-07-12 16:57:42]

https://codereview.chromium.org/2143473002/diff/40001/ui/views/controls/butto...
File ui/views/controls/button/label_button.cc (right):

https://codereview.chromium.org/2143473002/diff/40001/ui/views/controls/butto...
ui/views/controls/button/label_button.cc:544: Layout();
Interesting. Looks like PreferredSizeChanged() invalidates the layout, however,
the relayout never happens? Should we fix that instead?

[varkha, 2016-07-12 19:58:45]

https://codereview.chromium.org/2143473002/diff/40001/ui/views/controls/butto...
File ui/views/controls/button/label_button.cc (right):

https://codereview.chromium.org/2143473002/diff/40001/ui/views/controls/butto...
ui/views/controls/button/label_button.cc:544: Layout();
On 2016/07/12 16:57:42, sadrul wrote:
> Interesting. Looks like PreferredSizeChanged() invalidates the layout,
however,
> the relayout never happens? Should we fix that instead?

Discussed this offline. sadrul@ thought we could have 'ScheduleLayout()',
similar to SchedulePaint(). We already have InvalidateLayout() and perhaps that
could ensure that Layout() happens before the next paint.

Still in this case it is the Layout that triggers paint and there is nothing
else in this scenario like resizing to trigger layout or paint. This makes it
tricky.

[sadrul, 2016-07-13 00:16:23]

I have filed crbug.com/627663 to track possible optimization.

This lgtm

[varkha, 2016-07-13 06:53:14]

The CQ bit was checked by varkha@chromium.org

[commit-bot: I haz the power, 2016-07-13 06:53:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 08:37:10]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-07-13 08:40:36]

Description was changed from

==========
[ash-md] Updates window title if it is changed after entering overview

Need to call LabelButton::Layout since this requires updated preferred
width of the label and that needs up to date text.

BUG=624612
==========

to

==========
[ash-md] Updates window title if it is changed after entering overview

Need to call LabelButton::Layout since this requires updated preferred
width of the label and that needs up to date text.

BUG=624612

Committed: https://crrev.com/2bd9e5c30da7d762dfeac6dd2eee88aea9603f6e
Cr-Commit-Position: refs/heads/master@{#405083}
==========

[commit-bot: I haz the power, 2016-07-13 08:40:36]

Patchset 2 (id:??) landed as
https://crrev.com/2bd9e5c30da7d762dfeac6dd2eee88aea9603f6e
Cr-Commit-Position: refs/heads/master@{#405083}