Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2143443002: [Atomics] Rename Atomics.futex*, remove Atomics.futexWakeOrRequeue (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 months, 3 weeks ago by binji
Modified:
10 months, 2 weeks ago
Reviewers:
Jarin, Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Atomics] Rename Atomics.futex*, remove Atomics.futexWakeOrRequeue * Rename Atomics.futexWait -> Atomics.wait * Rename Atomics.futexWake -> Atomics.wake * Remove Atomics.futexWakeOrRequeue * Return value of Atomics.wait is now a string: "ok", "not-equal" or "timed-out" * Update comments that reference URL for ecmascript_sharedmem to https://github.com/tc39/ecmascript_sharedmem Committed: https://crrev.com/a16ca012e0ac4240a6f24489e1c8b6cbc35567cc Cr-Commit-Position: refs/heads/master@{#37727}

Patch Set 1 #

Patch Set 2 : merge master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -290 lines) Patch
M src/futex-emulation.h View 3 chunks +3 lines, -20 lines 0 comments Download
M src/futex-emulation.cc View 4 chunks +3 lines, -41 lines 0 comments Download
M src/heap-symbols.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/js/harmony-atomics.js View 4 chunks +6 lines, -29 lines 0 comments Download
M src/runtime/runtime.h View 1 2 chunks +4 lines, -8 lines 0 comments Download
M src/runtime/runtime-atomics.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-futex.cc View 1 3 chunks +4 lines, -28 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/futex.js View 13 chunks +31 lines, -162 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 12 (6 generated)
binji
+jarin review +littledan src/js/*
10 months, 3 weeks ago (2016-07-11 21:09:30 UTC) #3
Dan Ehrenberg
lgtm
10 months, 3 weeks ago (2016-07-11 22:01:53 UTC) #4
binji
Since this CL is mostly just renaming/removing, landing w/ Dan's lg.
10 months, 2 weeks ago (2016-07-13 18:27:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143443002/20001
10 months, 2 weeks ago (2016-07-13 18:27:13 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
10 months, 2 weeks ago (2016-07-13 18:29:55 UTC) #10
commit-bot: I haz the power
10 months, 2 weeks ago (2016-07-13 18:34:12 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a16ca012e0ac4240a6f24489e1c8b6cbc35567cc
Cr-Commit-Position: refs/heads/master@{#37727}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06