Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 214343002: Refactor SharedWorkerHost and SharedWorkerInstance. (Closed)

Created:
6 years, 9 months ago by horo
Modified:
6 years, 8 months ago
Reviewers:
kinuko
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Refactor SharedWorkerHost and SharedWorkerInstance. In this CL, I move the status variables of SharedWorker from SharedWorkerInstance to SharedWorkerHost. The main purpose of this change is to make it possible to pass SharedWorkerInstance to SharedWorkerDevToolsManager and store it in WorkerInfo in http://crrev.com/196503005. BUG=327256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260489

Patch Set 1 #

Patch Set 2 : fix error #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -140 lines) Patch
M content/browser/shared_worker/shared_worker_host.h View 1 2 4 chunks +37 lines, -0 lines 0 comments Download
M content/browser/shared_worker/shared_worker_host.cc View 1 2 13 chunks +63 lines, -24 lines 0 comments Download
M content/browser/shared_worker/shared_worker_instance.h View 1 5 chunks +5 lines, -45 lines 0 comments Download
M content/browser/shared_worker/shared_worker_instance.cc View 3 chunks +1 line, -49 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.cc View 1 5 chunks +23 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
horo
kinuko@ Could you please review?
6 years, 9 months ago (2014-03-27 07:44:07 UTC) #1
kinuko
looks good Is this basically for cleanup? Could you tell the main purpose of this ...
6 years, 8 months ago (2014-03-28 11:12:49 UTC) #2
horo
On 2014/03/28 11:12:49, kinuko wrote: > looks good > > Is this basically for cleanup? ...
6 years, 8 months ago (2014-03-29 00:37:22 UTC) #3
kinuko
On 2014/03/29 00:37:22, horo wrote: > On 2014/03/28 11:12:49, kinuko wrote: > > looks good ...
6 years, 8 months ago (2014-03-31 00:59:32 UTC) #4
horo
On 2014/03/31 00:59:32, kinuko wrote: > On 2014/03/29 00:37:22, horo wrote: > > On 2014/03/28 ...
6 years, 8 months ago (2014-03-31 01:08:45 UTC) #5
horo
The CQ bit was checked by horo@chromium.org
6 years, 8 months ago (2014-03-31 01:08:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/214343002/60001
6 years, 8 months ago (2014-03-31 01:08:58 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 03:20:35 UTC) #8
Message was sent while issue was closed.
Change committed as 260489

Powered by Google App Engine
This is Rietveld 408576698