Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 21434: Don't unpatch an unloaded module. We verify if the original function address ... (Closed)

Created:
11 years, 10 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
Dean McNamee, amit
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Don't unpatch an unloaded module. We verify if the original function address is still valid with a VirtualQuery call. This fixes http://code.google.com/p/chromium/issues/detail?id=7701 Bug=7701 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9929

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M base/iat_patch.cc View 1 chunk +19 lines, -3 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
ananta
11 years, 10 months ago (2009-02-17 22:47:02 UTC) #1
amit
OK
11 years, 10 months ago (2009-02-17 23:21:13 UTC) #2
amit
OK
11 years, 10 months ago (2009-02-17 23:21:19 UTC) #3
Dean McNamee
http://codereview.chromium.org/21434/diff/1/2 File base/iat_patch.cc (right): http://codereview.chromium.org/21434/diff/1/2#newcode217 Line 217: } Shouldn't you set all of the functions ...
11 years, 10 months ago (2009-02-18 11:35:38 UTC) #4
Dean McNamee
11 years, 10 months ago (2009-02-18 12:48:46 UTC) #5
What if this area of the VA space was reused after the module was unloaded?  I
really think the underlying plugin issue should be fixed, as this is just a
bandaid (might as well have just wrapped it all around an catchall SEH handler).

On 2009/02/18 11:35:38, Dean McNamee wrote:
> http://codereview.chromium.org/21434/diff/1/2
> File base/iat_patch.cc (right):
> 
> http://codereview.chromium.org/21434/diff/1/2#newcode217
> Line 217: }
> Shouldn't you set all of the functions to NULL here?

Powered by Google App Engine
This is Rietveld 408576698