Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: components/translate.gypi

Issue 2143383002: [Translate] Migrate IPCs to Mojo interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from Ken Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate.gypi
diff --git a/components/translate.gypi b/components/translate.gypi
index d4babfa7335ffca86cebc12f733b9b061a8ca858..7f308d3acedca8ae98a7e033da933cd1c402b621 100644
--- a/components/translate.gypi
+++ b/components/translate.gypi
@@ -132,7 +132,7 @@
'target_name': 'translate_content_browser',
'type': 'static_library',
'dependencies': [
- 'translate_content_common',
+ 'translate_content_mojo_bindings',
'translate_core_browser',
'../base/base.gyp:base',
'../content/content.gyp:content_browser',
@@ -147,37 +147,45 @@
],
},
{
- # GN version: //components/translate/content/common
- 'target_name': 'translate_content_common',
+ # GN version: //components/translate/content/public/interfaces
+ 'target_name': 'translate_content_mojo_bindings',
'type': 'static_library',
+ 'variables': {
+ 'mojom_typemaps': [
+ 'translate/content/public/cpp/translate.typemap',
+ '<(DEPTH)/mojo/common/common_custom_types.typemap',
+ '<(DEPTH)/url/mojo/gurl.typemap',
+ ],
+ },
+ 'sources': [
+ 'translate/content/public/cpp/translate_struct_traits.cc',
+ 'translate/content/public/interfaces/translate.mojom',
+ ],
+ 'export_dependent_settings': [
+ '../mojo/mojo_base.gyp:mojo_common_custom_types_mojom',
+ '../url/url.gyp:url_mojom',
+ ],
'dependencies': [
'translate_core_common',
'translate_core_language_detection',
'../base/base.gyp:base',
- '../ipc/ipc.gyp:ipc',
- '../url/ipc/url_ipc.gyp:url_ipc',
+ '../mojo/mojo_base.gyp:mojo_common_custom_types_mojom',
+ '../mojo/mojo_public.gyp:mojo_cpp_bindings',
+ '../url/url.gyp:url_mojom',
],
- 'include_dirs': [
- '..',
- ],
- 'sources': [
- # Note: sources list duplicated in GN build.
- 'translate/content/common/translate_messages.cc',
- 'translate/content/common/translate_messages.h',
- ],
+ 'includes': [ '../mojo/mojom_bindings_generator.gypi' ],
},
{
# GN version: //components/translate/content/renderer
'target_name': 'translate_content_renderer',
'type': 'static_library',
'dependencies': [
- 'translate_content_common',
+ 'translate_content_mojo_bindings',
'translate_core_common',
'translate_core_language_detection',
'../base/base.gyp:base',
'../content/content.gyp:content_common',
'../content/content.gyp:content_renderer',
- '../ipc/ipc.gyp:ipc',
'../third_party/WebKit/public/blink.gyp:blink',
'../third_party/cld_2/cld_2.gyp:cld_2',
'../url/url.gyp:url_lib',

Powered by Google App Engine
This is Rietveld 408576698