Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2143383002: [Translate] Migrate IPCs to Mojo interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from Ken Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index b029d3182de5c91a50a55ed80469af0e4c6c11d5..64d7132f8a1ca23fe3429b6f08e3382752e13a79 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -82,6 +82,7 @@
#include "chrome/browser/sync_file_system/local/sync_file_system_backend.h"
#include "chrome/browser/tab_contents/tab_util.h"
#include "chrome/browser/tracing/chrome_tracing_delegate.h"
+#include "chrome/browser/translate/chrome_translate_client.h"
#include "chrome/browser/ui/blocked_content/blocked_window_params.h"
#include "chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h"
#include "chrome/browser/ui/browser_navigator.h"
@@ -2824,6 +2825,12 @@ void ChromeContentBrowserClient::RegisterRenderFrameMojoInterfaces(
base::Bind(&autofill::ContentAutofillDriverFactory::BindAutofillDriver,
render_frame_host));
+ // Register mojo ContentTranslateDriver interface only for main frame.
Tom Sepez 2016/08/01 17:08:17 nit: does the order matter? Can/Should we combine
leonhsl(Using Gerrit) 2016/08/02 02:52:23 Yeah good point! Sorry for my carelessness. Done a
+ if (!render_frame_host->GetParent()) {
+ registry->AddInterface(base::Bind(
+ &ChromeTranslateClient::BindContentTranslateDriver, render_frame_host));
+ }
+
#if BUILDFLAG(ANDROID_JAVA_UI)
ChromeServiceRegistrarAndroid::RegisterRenderFrameMojoInterfaces(
registry, render_frame_host);

Powered by Google App Engine
This is Rietveld 408576698