Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: components/translate/content/browser/content_translate_driver.cc

Issue 2143383002: [Translate] Migrate IPCs to Mojo interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from Tom Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/translate/content/browser/content_translate_driver.h" 5 #include "components/translate/content/browser/content_translate_driver.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/single_thread_task_runner.h" 10 #include "base/single_thread_task_runner.h"
11 #include "base/threading/thread_task_runner_handle.h" 11 #include "base/threading/thread_task_runner_handle.h"
12 #include "components/translate/content/common/translate_messages.h"
13 #include "components/translate/core/browser/translate_download_manager.h" 12 #include "components/translate/core/browser/translate_download_manager.h"
14 #include "components/translate/core/browser/translate_manager.h" 13 #include "components/translate/core/browser/translate_manager.h"
15 #include "content/public/browser/browser_context.h" 14 #include "content/public/browser/browser_context.h"
16 #include "content/public/browser/navigation_controller.h" 15 #include "content/public/browser/navigation_controller.h"
17 #include "content/public/browser/navigation_details.h" 16 #include "content/public/browser/navigation_details.h"
18 #include "content/public/browser/navigation_entry.h" 17 #include "content/public/browser/navigation_entry.h"
19 #include "content/public/browser/page_navigator.h" 18 #include "content/public/browser/page_navigator.h"
20 #include "content/public/browser/render_frame_host.h" 19 #include "content/public/browser/render_frame_host.h"
21 #include "content/public/browser/web_contents.h" 20 #include "content/public/browser/web_contents.h"
22 #include "content/public/common/referrer.h" 21 #include "content/public/common/referrer.h"
23 #include "net/http/http_status_code.h" 22 #include "net/http/http_status_code.h"
24 #include "url/gurl.h" 23 #include "url/gurl.h"
25 24
26 namespace { 25 namespace {
27 26
28 // The maximum number of attempts we'll do to see if the page has finshed 27 // The maximum number of attempts we'll do to see if the page has finshed
29 // loading before giving up the translation 28 // loading before giving up the translation
30 const int kMaxTranslateLoadCheckAttempts = 20; 29 const int kMaxTranslateLoadCheckAttempts = 20;
31 30
32 } // namespace 31 } // namespace
33 32
34 namespace translate { 33 namespace translate {
35 34
36 ContentTranslateDriver::ContentTranslateDriver( 35 ContentTranslateDriver::ContentTranslateDriver(
37 content::NavigationController* nav_controller) 36 content::NavigationController* nav_controller)
38 : content::WebContentsObserver(nav_controller->GetWebContents()), 37 : content::WebContentsObserver(nav_controller->GetWebContents()),
39 navigation_controller_(nav_controller), 38 navigation_controller_(nav_controller),
40 translate_manager_(NULL), 39 translate_manager_(NULL),
41 max_reload_check_attempts_(kMaxTranslateLoadCheckAttempts), 40 max_reload_check_attempts_(kMaxTranslateLoadCheckAttempts),
41 next_page_seq_no_(0),
42 weak_pointer_factory_(this) { 42 weak_pointer_factory_(this) {
43 DCHECK(navigation_controller_); 43 DCHECK(navigation_controller_);
44 } 44 }
45 45
46 ContentTranslateDriver::~ContentTranslateDriver() {} 46 ContentTranslateDriver::~ContentTranslateDriver() {}
47 47
48 void ContentTranslateDriver::BindRequest(
49 mojom::ContentTranslateDriverRequest request) {
50 bindings_.AddBinding(this, std::move(request));
51 }
52
48 void ContentTranslateDriver::AddObserver(Observer* observer) { 53 void ContentTranslateDriver::AddObserver(Observer* observer) {
49 observer_list_.AddObserver(observer); 54 observer_list_.AddObserver(observer);
50 } 55 }
51 56
52 void ContentTranslateDriver::RemoveObserver(Observer* observer) { 57 void ContentTranslateDriver::RemoveObserver(Observer* observer) {
53 observer_list_.RemoveObserver(observer); 58 observer_list_.RemoveObserver(observer);
54 } 59 }
55 60
56 void ContentTranslateDriver::InitiateTranslation(const std::string& page_lang, 61 void ContentTranslateDriver::InitiateTranslation(const std::string& page_lang,
57 int attempt) { 62 int attempt) {
(...skipping 24 matching lines...) Expand all
82 return navigation_controller_ && 87 return navigation_controller_ &&
83 navigation_controller_->GetLastCommittedEntry() && 88 navigation_controller_->GetLastCommittedEntry() &&
84 ui::PageTransitionCoreTypeIs( 89 ui::PageTransitionCoreTypeIs(
85 navigation_controller_->GetLastCommittedEntry() 90 navigation_controller_->GetLastCommittedEntry()
86 ->GetTransitionType(), 91 ->GetTransitionType(),
87 ui::PAGE_TRANSITION_LINK); 92 ui::PAGE_TRANSITION_LINK);
88 } 93 }
89 94
90 void ContentTranslateDriver::OnTranslateEnabledChanged() { 95 void ContentTranslateDriver::OnTranslateEnabledChanged() {
91 content::WebContents* web_contents = navigation_controller_->GetWebContents(); 96 content::WebContents* web_contents = navigation_controller_->GetWebContents();
92 FOR_EACH_OBSERVER( 97 FOR_EACH_OBSERVER(Observer, observer_list_,
93 Observer, observer_list_, OnTranslateEnabledChanged(web_contents)); 98 OnTranslateEnabledChanged(web_contents));
94 } 99 }
95 100
96 void ContentTranslateDriver::OnIsPageTranslatedChanged() { 101 void ContentTranslateDriver::OnIsPageTranslatedChanged() {
97 content::WebContents* web_contents = 102 content::WebContents* web_contents = navigation_controller_->GetWebContents();
98 navigation_controller_->GetWebContents(); 103 FOR_EACH_OBSERVER(Observer, observer_list_,
99 FOR_EACH_OBSERVER( 104 OnIsPageTranslatedChanged(web_contents));
100 Observer, observer_list_, OnIsPageTranslatedChanged(web_contents));
101 } 105 }
102 106
103 void ContentTranslateDriver::TranslatePage(int page_seq_no, 107 void ContentTranslateDriver::TranslatePage(int page_seq_no,
104 const std::string& translate_script, 108 const std::string& translate_script,
105 const std::string& source_lang, 109 const std::string& source_lang,
106 const std::string& target_lang) { 110 const std::string& target_lang) {
107 content::WebContents* web_contents = navigation_controller_->GetWebContents(); 111 auto it = pages_.find(page_seq_no);
108 web_contents->GetMainFrame()->Send(new ChromeFrameMsg_TranslatePage( 112 if (it == pages_.end())
109 web_contents->GetMainFrame()->GetRoutingID(), page_seq_no, 113 return; // This page has navigated away.
110 translate_script, source_lang, target_lang)); 114
115 it->second->Translate(translate_script, source_lang, target_lang,
116 base::Bind(&ContentTranslateDriver::OnPageTranslated,
117 base::Unretained(this)));
111 } 118 }
112 119
113 void ContentTranslateDriver::RevertTranslation(int page_seq_no) { 120 void ContentTranslateDriver::RevertTranslation(int page_seq_no) {
114 content::WebContents* web_contents = navigation_controller_->GetWebContents(); 121 auto it = pages_.find(page_seq_no);
115 web_contents->GetMainFrame()->Send(new ChromeFrameMsg_RevertTranslation( 122 if (it == pages_.end())
116 web_contents->GetMainFrame()->GetRoutingID(), page_seq_no)); 123 return; // This page has navigated away.
124
125 it->second->RevertTranslation();
117 } 126 }
118 127
119 bool ContentTranslateDriver::IsOffTheRecord() { 128 bool ContentTranslateDriver::IsOffTheRecord() {
120 return navigation_controller_->GetBrowserContext()->IsOffTheRecord(); 129 return navigation_controller_->GetBrowserContext()->IsOffTheRecord();
121 } 130 }
122 131
123 const std::string& ContentTranslateDriver::GetContentsMimeType() { 132 const std::string& ContentTranslateDriver::GetContentsMimeType() {
124 return navigation_controller_->GetWebContents()->GetContentsMimeType(); 133 return navigation_controller_->GetWebContents()->GetContentsMimeType();
125 } 134 }
126 135
127 const GURL& ContentTranslateDriver::GetLastCommittedURL() { 136 const GURL& ContentTranslateDriver::GetLastCommittedURL() {
128 return navigation_controller_->GetWebContents()->GetLastCommittedURL(); 137 return navigation_controller_->GetWebContents()->GetLastCommittedURL();
129 } 138 }
130 139
131 const GURL& ContentTranslateDriver::GetVisibleURL() { 140 const GURL& ContentTranslateDriver::GetVisibleURL() {
132 return navigation_controller_->GetWebContents()->GetVisibleURL(); 141 return navigation_controller_->GetWebContents()->GetVisibleURL();
133 } 142 }
134 143
135 bool ContentTranslateDriver::HasCurrentPage() { 144 bool ContentTranslateDriver::HasCurrentPage() {
136 return (navigation_controller_->GetLastCommittedEntry() != NULL); 145 return (navigation_controller_->GetLastCommittedEntry() != NULL);
137 } 146 }
138 147
139 void ContentTranslateDriver::OpenUrlInNewTab(const GURL& url) { 148 void ContentTranslateDriver::OpenUrlInNewTab(const GURL& url) {
140 content::OpenURLParams params(url, 149 content::OpenURLParams params(url, content::Referrer(), NEW_FOREGROUND_TAB,
141 content::Referrer(), 150 ui::PAGE_TRANSITION_LINK, false);
142 NEW_FOREGROUND_TAB,
143 ui::PAGE_TRANSITION_LINK,
144 false);
145 navigation_controller_->GetWebContents()->OpenURL(params); 151 navigation_controller_->GetWebContents()->OpenURL(params);
146 } 152 }
147 153
148 // content::WebContentsObserver methods 154 // content::WebContentsObserver methods
149 155
150 void ContentTranslateDriver::NavigationEntryCommitted( 156 void ContentTranslateDriver::NavigationEntryCommitted(
151 const content::LoadCommittedDetails& load_details) { 157 const content::LoadCommittedDetails& load_details) {
152 // Check whether this is a reload: When doing a page reload, the 158 // Check whether this is a reload: When doing a page reload, the
153 // TranslateLanguageDetermined IPC is not sent so the translation needs to be 159 // TranslateLanguageDetermined IPC is not sent so the translation needs to be
154 // explicitly initiated. 160 // explicitly initiated.
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 const content::FrameNavigateParams& params) { 209 const content::FrameNavigateParams& params) {
204 // Let the LanguageState clear its state. 210 // Let the LanguageState clear its state.
205 const bool reload = 211 const bool reload =
206 ui::PageTransitionCoreTypeIs(details.entry->GetTransitionType(), 212 ui::PageTransitionCoreTypeIs(details.entry->GetTransitionType(),
207 ui::PAGE_TRANSITION_RELOAD) || 213 ui::PAGE_TRANSITION_RELOAD) ||
208 details.type == content::NAVIGATION_TYPE_SAME_PAGE; 214 details.type == content::NAVIGATION_TYPE_SAME_PAGE;
209 translate_manager_->GetLanguageState().DidNavigate( 215 translate_manager_->GetLanguageState().DidNavigate(
210 details.is_in_page, details.is_main_frame, reload); 216 details.is_in_page, details.is_main_frame, reload);
211 } 217 }
212 218
213 bool ContentTranslateDriver::OnMessageReceived( 219 void ContentTranslateDriver::OnPageAway(int page_seq_no) {
groby-ooo-7-16 2016/08/04 02:35:58 Not quite clear what that function name means - I
leonhsl(Using Gerrit) 2016/08/04 08:41:09 Each time RegisterPage() gets called, 'Page' means
214 const IPC::Message& message, 220 pages_.erase(page_seq_no);
215 content::RenderFrameHost* render_frame_host) {
216 bool handled = true;
217 IPC_BEGIN_MESSAGE_MAP(ContentTranslateDriver, message)
218 IPC_MESSAGE_HANDLER(ChromeFrameHostMsg_TranslateAssignedSequenceNumber,
219 OnTranslateAssignedSequenceNumber)
220 IPC_MESSAGE_HANDLER(ChromeFrameHostMsg_TranslateLanguageDetermined,
221 OnLanguageDetermined)
222 IPC_MESSAGE_HANDLER(ChromeFrameHostMsg_PageTranslated, OnPageTranslated)
223 IPC_MESSAGE_UNHANDLED(handled = false)
224 IPC_END_MESSAGE_MAP()
225 return handled;
226 } 221 }
227 222
228 void ContentTranslateDriver::OnTranslateAssignedSequenceNumber( 223 // mojom::ContentTranslateDriver implementation.
229 int page_seq_no) { 224 void ContentTranslateDriver::RegisterPage(
230 translate_manager_->set_current_seq_no(page_seq_no); 225 mojom::PagePtr page,
231 }
232
233 void ContentTranslateDriver::OnLanguageDetermined(
234 const LanguageDetectionDetails& details, 226 const LanguageDetectionDetails& details,
235 bool page_needs_translation) { 227 bool page_needs_translation) {
228 pages_[++next_page_seq_no_] = std::move(page);
229 pages_[next_page_seq_no_].set_connection_error_handler(
230 base::Bind(&ContentTranslateDriver::OnPageAway, base::Unretained(this),
231 next_page_seq_no_));
232 translate_manager_->set_current_seq_no(next_page_seq_no_);
233
236 translate_manager_->GetLanguageState().LanguageDetermined( 234 translate_manager_->GetLanguageState().LanguageDetermined(
237 details.adopted_language, page_needs_translation); 235 details.adopted_language, page_needs_translation);
238 236
239 if (web_contents()) 237 if (web_contents())
240 translate_manager_->InitiateTranslation(details.adopted_language); 238 translate_manager_->InitiateTranslation(details.adopted_language);
241 239
242 FOR_EACH_OBSERVER(Observer, observer_list_, OnLanguageDetermined(details)); 240 FOR_EACH_OBSERVER(Observer, observer_list_, OnLanguageDetermined(details));
243 } 241 }
244 242
245 void ContentTranslateDriver::OnPageTranslated( 243 void ContentTranslateDriver::OnPageTranslated(
244 bool cancelled,
246 const std::string& original_lang, 245 const std::string& original_lang,
247 const std::string& translated_lang, 246 const std::string& translated_lang,
248 TranslateErrors::Type error_type) { 247 TranslateErrors::Type error_type) {
249 translate_manager_->PageTranslated( 248 if (cancelled)
250 original_lang, translated_lang, error_type); 249 return;
250
251 translate_manager_->PageTranslated(original_lang, translated_lang,
252 error_type);
251 FOR_EACH_OBSERVER( 253 FOR_EACH_OBSERVER(
252 Observer, 254 Observer, observer_list_,
253 observer_list_,
254 OnPageTranslated(original_lang, translated_lang, error_type)); 255 OnPageTranslated(original_lang, translated_lang, error_type));
255 } 256 }
256 257
257 } // namespace translate 258 } // namespace translate
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698