Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2143363003:
Add a new mb_config.pyl entry for Cronet Release ASAN bot (Closed)
DescriptionAdd a new mb_config.pyl entry for Cronet Release ASAN bot
This CLs adds an entry in mb_config.pyl for a new Cronet Release Asan bot.
BUG=567323
Committed: https://crrev.com/92b55915ba83a153fefb89bcb4ecffabad7ea029
Cr-Commit-Position: refs/heads/master@{#405186}
Patch Set 1 #
Total comments: 2
Patch Set 2 : address comments #Messages
Total messages: 20 (10 generated)
Patchset #1 (id:1) has been deleted
xunjieli@chromium.org changed reviewers: + jbudorick@chromium.org
PTAL. Thanks!
lgtm w/ nit https://codereview.chromium.org/2143363003/diff/20001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2143363003/diff/20001/tools/mb/mb_config.pyl#... tools/mb/mb_config.pyl:29: 'Android Cronet Builder Asan': nit: move this below Android Cronet Builder (dbg)
Thanks! https://codereview.chromium.org/2143363003/diff/20001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2143363003/diff/20001/tools/mb/mb_config.pyl#... tools/mb/mb_config.pyl:29: 'Android Cronet Builder Asan': On 2016/07/13 14:54:59, jbudorick wrote: > nit: move this below Android Cronet Builder (dbg) Done.
The CQ bit was checked by xunjieli@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jbudorick@chromium.org Link to the patchset: https://codereview.chromium.org/2143363003/#ps40001 (title: "address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/07/13 14:58:19, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... Beware that I'm not an owner here.
Description was changed from ========== Add a new mb_config.pyl entry for Cronet Release ASAN bot This CLs adds an entry in mb_config.pyl for a new Cronet Release Asan bot. BUG=567323 ========== to ========== Add a new mb_config.pyl entry for Cronet Release ASAN bot This CLs adds an entry in mb_config.pyl for a new Cronet Release Asan bot. BUG=567323 ==========
xunjieli@chromium.org changed reviewers: + dpranke@chromium.org
The CQ bit was unchecked by xunjieli@chromium.org
On 2016/07/13 14:59:05, jbudorick wrote: > On 2016/07/13 14:58:19, commit-bot: I haz the power wrote: > > CQ is trying da patch. Follow status at > > > > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... > > Beware that I'm not an owner here. Thought you were an owner of everything, so I didn't check :). Thanks for letting me know. dpranke@: could you take a look?
lgtm
The CQ bit was checked by xunjieli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add a new mb_config.pyl entry for Cronet Release ASAN bot This CLs adds an entry in mb_config.pyl for a new Cronet Release Asan bot. BUG=567323 ========== to ========== Add a new mb_config.pyl entry for Cronet Release ASAN bot This CLs adds an entry in mb_config.pyl for a new Cronet Release Asan bot. BUG=567323 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add a new mb_config.pyl entry for Cronet Release ASAN bot This CLs adds an entry in mb_config.pyl for a new Cronet Release Asan bot. BUG=567323 ========== to ========== Add a new mb_config.pyl entry for Cronet Release ASAN bot This CLs adds an entry in mb_config.pyl for a new Cronet Release Asan bot. BUG=567323 Committed: https://crrev.com/92b55915ba83a153fefb89bcb4ecffabad7ea029 Cr-Commit-Position: refs/heads/master@{#405186} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/92b55915ba83a153fefb89bcb4ecffabad7ea029 Cr-Commit-Position: refs/heads/master@{#405186} |
