Spec: Allow any expression in assert statements.

Spec: Allow any expression in assert statements.

Fixes issue #26866

BUG= http://dartbug.com/26866
R=eernst@google.com, floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/04a470e6362917de1056c2ff87ddf64d05844f1c

[Lasse Reichstein Nielsen, 2016-07-13 08:18:12]

lrn@google.com changed reviewers:
+ eernst@google.com, floitsch@google.com

[floitsch, 2016-07-13 10:51:03]

LGTM.

[floitsch, 2016-07-13 10:51:30]

Maybe update the changelog with this commit?
or should we do it with the analyzer commit?

[eernst, 2016-07-15 15:17:08]

On 2016/07/13 10:51:30, floitsch wrote:
> Maybe update the changelog with this commit?
> or should we do it with the analyzer commit?

The global CHANGELOG.md has a sparse history of mentioning
language changes, but it might be a good habit to start
describing language changes there more systematically.

We could put more emphasis on using the `LMHash` stuff
to compare different versions of the spec, which basically
means that the description in CHANGELOG.md can be quite brief
and informal.

[floitsch, 2016-07-29 20:15:33]

On 2016/07/15 15:17:08, eernst wrote:
> On 2016/07/13 10:51:30, floitsch wrote:
> > Maybe update the changelog with this commit?
> > or should we do it with the analyzer commit?
> 
> The global CHANGELOG.md has a sparse history of mentioning
> language changes, but it might be a good habit to start
> describing language changes there more systematically.
> 
> We could put more emphasis on using the `LMHash` stuff
> to compare different versions of the spec, which basically
> means that the description in CHANGELOG.md can be quite brief
> and informal.

Any change that is user-visible should be in the changelog. Sometimes we want to
add features/changes in stealth-mode, but, even then, we should add the messages
to the changelog at some point. ("Commit to XY which was added in ...")

[eernst, 2016-08-01 07:24:35]

(I did not intend to hold this CL back, so here's an explicit LGTM)

[eernst, 2016-08-01 07:24:38]

(I did not intend to hold this CL back, so here's an explicit LGTM)

[Lasse Reichstein Nielsen, 2016-08-15 09:28:48]

I think we should not say anything for now, and just include it in the change to
allow a second parameter.

[Lasse Reichstein Nielsen, 2016-08-15 09:59:27]

Description was changed from

==========
Spec: Allow any expression in assert statements.

Fixes issue #26866

BUG= http://dartbug.com/26866
==========

to

==========
Spec: Allow any expression in assert statements.

Fixes issue #26866

BUG= http://dartbug.com/26866
R=eernst@google.com, floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/04a470e6362917de1056c2ff87ddf64d05844f1c
==========

[Lasse Reichstein Nielsen, 2016-08-15 09:59:28]

Committed patchset #1 (id:1) manually as
04a470e6362917de1056c2ff87ddf64d05844f1c (presubmit successful).