src/gpu/instanced/InstancedRendering.cpp - Issue 2143333002: Add resource provider flag to avoid client-side buffers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/instanced/InstancedRendering.cpp

Issue 2143333002: Add resource provider flag to avoid client-side buffers (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add resource provider flag to avoid client-side buffers Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/instanced/InstancedRendering.cpp

diff --git a/src/gpu/instanced/InstancedRendering.cpp b/src/gpu/instanced/InstancedRendering.cpp

index fd9df6efe9dc7a73537c712c594f794ba08034cb..c23ec6b9542b7642efd172de14476e7a225e5320 100644

--- a/src/gpu/instanced/InstancedRendering.cpp

+++ b/src/gpu/instanced/InstancedRendering.cpp

@@ -452,7 +452,8 @@ void InstancedRendering::beginFlush(GrResourceProvider* rp) {

if (!fParams.empty()) {

fParamsBuffer.reset(rp->createBuffer(fParams.count() * sizeof(ParamsTexel),

kTexel_GrBufferType, kDynamic_GrAccessPattern,

- GrResourceProvider::kNoPendingIO_Flag,

+ GrResourceProvider::kNoPendingIO_Flag |

+ GrResourceProvider::kRequireVBO_Flag,

fParams.begin()));

if (!fParamsBuffer) {

return;