Refactoring MatchRanges and RuleRange.

Refactoring MatchRanges and RuleRange.

TEST=no new tests, just refactoring.
BUG=172051
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170175

[tasak, 2014-03-27 08:31:24]

Would you review this CL?

I would like to make it easier to create and modify RuleRange for CSS property
"all".

[esprehn, 2014-03-27 08:41:59]

lgtm, please fix nits before landing.

https://codereview.chromium.org/214333003/diff/1/Source/core/css/resolver/Mat...
File Source/core/css/resolver/MatchResult.h (right):

https://codereview.chromium.org/214333003/diff/1/Source/core/css/resolver/Mat...
Source/core/css/resolver/MatchResult.h:39: RuleRange(int firstRuleIndex, int
lastRuleIndex) : m_firstRuleIndex(firstRuleIndex),
m_lastRuleIndex(lastRuleIndex) { }
The initializer should be on a different line.

RuleRange(...)
 : m_firstRuleIndex(...)
 , m_lastRuleIndex(...)
{
}

https://codereview.chromium.org/214333003/diff/1/Source/core/css/resolver/Mat...
Source/core/css/resolver/MatchResult.h:50: m_lastRuleIndex = position;
This doesn't seem to shift the last, it seems to actually set it?

https://codereview.chromium.org/214333003/diff/1/Source/core/css/resolver/Mat...
Source/core/css/resolver/MatchResult.h:74: MatchRanges() { }
Leave off the default constructor, the compiler will make it for you.

https://codereview.chromium.org/214333003/diff/1/Source/core/css/resolver/Mat...
Source/core/css/resolver/MatchResult.h:76: RuleRange& UARuleRange() { return
m_uaRuleRange; }
ua should be lower case.

https://codereview.chromium.org/214333003/diff/1/Source/core/css/resolver/Mat...
Source/core/css/resolver/MatchResult.h:80: const RuleRange& UARuleRange() const
{ return m_uaRuleRange; }
ditto

[esprehn, 2014-03-27 13:19:05]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-03-27 13:19:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tasak@google.com/214333003/1

[commit-bot: I haz the power, 2014-03-27 13:29:33]

Change committed as 170175