Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2143323002: Remove WebPrivateOwnPtr (Closed)

Created:
4 years, 5 months ago by kinuko
Modified:
4 years, 5 months ago
Reviewers:
dcheng
CC:
chromium-reviews, aboxhall, dglazkov+blink, nektarios, dmazzoni, blink-reviews, je_julie, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebPrivateOwnPtr BUG=n/a Committed: https://crrev.com/b09ef0010c97bf25de363a91bdd4b865f4751ad4 Cr-Commit-Position: refs/heads/master@{#405433}

Patch Set 1 : #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -168 lines) Patch
M third_party/WebKit/Source/platform/exported/WebBlobData.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebFont.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebSocketHandshakeResponseInfo.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebScopedUserGesture.cpp View 1 1 chunk +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/WebScopedWindowFocusAllowedIndicator.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebSurroundingText.cpp View 1 2 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebBlobData.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebFont.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebLayerTreeView.h View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/public/platform/WebPrivateOwnPtr.h View 1 chunk +0 lines, -113 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLResponse.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/websockets/WebSocketHandshakeResponseInfo.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebAXObject.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebFrame.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebScopedUserGesture.h View 1 2 chunks +6 lines, -9 lines 0 comments Download
M third_party/WebKit/public/web/WebScopedWindowFocusAllowedIndicator.h View 1 2 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/public/web/WebSurroundingText.h View 1 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 38 (33 generated)
kinuko
I got somehow motivated to do a little more cleanup around here... PTL
4 years, 5 months ago (2016-07-13 23:41:14 UTC) #31
dcheng
LGTM!
4 years, 5 months ago (2016-07-14 03:48:37 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143323002/100001
4 years, 5 months ago (2016-07-14 04:26:43 UTC) #34
commit-bot: I haz the power
Committed patchset #2 (id:100001)
4 years, 5 months ago (2016-07-14 04:30:30 UTC) #36
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 04:32:13 UTC) #38
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b09ef0010c97bf25de363a91bdd4b865f4751ad4
Cr-Commit-Position: refs/heads/master@{#405433}

Powered by Google App Engine
This is Rietveld 408576698