Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright 2016 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2016 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. --> | 4 found in the LICENSE file. --> |
| 5 | 5 |
| 6 <org.chromium.chrome.browser.download.ui.DownloadManagerUi | 6 <org.chromium.chrome.browser.download.ui.DownloadManagerUi |
| 7 xmlns:android="http://schemas.android.com/apk/res/android" | 7 xmlns:android="http://schemas.android.com/apk/res/android" |
| 8 android:layout_width="match_parent" | 8 android:layout_width="match_parent" |
| 9 android:layout_height="match_parent" > | 9 android:layout_height="match_parent" > |
| 10 | 10 |
| 11 <!-- MAIN CONTENT --> | 11 <!-- MAIN CONTENT --> |
| 12 <RelativeLayout | 12 <RelativeLayout |
|
Ian Wen
2016/07/14 18:16:25
This layout could be simplified to LinearLayout. Y
gone
2016/07/14 19:11:56
Done.
| |
| 13 android:id="@+id/content_frame" | 13 android:id="@+id/content_frame" |
| 14 android:layout_width="match_parent" | 14 android:layout_width="match_parent" |
| 15 android:layout_height="match_parent" | 15 android:layout_height="match_parent" |
| 16 android:background="#ffffff"> | 16 android:background="#ffffff"> |
| 17 | 17 |
| 18 <org.chromium.chrome.browser.download.ui.DownloadManagerToolbar | 18 <org.chromium.chrome.browser.download.ui.DownloadManagerToolbar |
| 19 android:id="@id/action_bar" | 19 android:id="@id/action_bar" |
| 20 android:layout_width="match_parent" | 20 android:layout_width="match_parent" |
| 21 android:layout_height="?attr/actionBarSize" | 21 android:layout_height="?attr/actionBarSize" |
| 22 android:layout_alignParentTop="true" | 22 android:layout_alignParentTop="true" |
| 23 android:layout_alignParentStart="true" | 23 android:layout_alignParentStart="true" |
| 24 android:layout_alignParentEnd="true" | 24 android:layout_alignParentEnd="true" |
| 25 android:background="@color/appbar_background" > | 25 android:background="@color/appbar_background" /> |
| 26 </org.chromium.chrome.browser.download.ui.DownloadManagerToolbar> | 26 |
| 27 <android.support.v7.widget.RecyclerView | |
| 28 android:id="@+id/recycler_view" | |
| 29 android:layout_width="match_parent" | |
| 30 android:layout_height="0dp" | |
| 31 android:layout_below="@id/action_bar" | |
| 32 android:layout_alignParentBottom="true" | |
| 33 android:layout_alignParentStart="true" | |
| 34 android:layout_alignParentEnd="true" /> | |
| 27 | 35 |
| 28 <org.chromium.chrome.browser.widget.FadingShadowView | 36 <org.chromium.chrome.browser.widget.FadingShadowView |
| 29 android:id="@+id/shadow" | 37 android:id="@+id/shadow" |
| 30 android:layout_width="match_parent" | 38 android:layout_width="match_parent" |
| 31 android:layout_height="10dp" | 39 android:layout_height="10dp" |
| 32 android:layout_below="@id/action_bar" /> | 40 android:layout_below="@id/action_bar" /> |
| 33 | 41 |
| 34 <!-- Insert RecyclerView here for showing items (or lack thereof). --> | |
| 35 </RelativeLayout> | 42 </RelativeLayout> |
| 36 | 43 |
| 37 <!-- NAVIGATION DRAWER | 44 <!-- NAVIGATION DRAWER |
| 38 We can't assign a paddingStart or paddingEnd because the section highli ghts are full-bleed. | 45 We can't assign a paddingStart or paddingEnd because the section highli ghts are full-bleed. |
| 39 --> | 46 --> |
| 40 <LinearLayout | 47 <LinearLayout |
| 41 android:id="@+id/drawer_layout" | 48 android:id="@+id/drawer_layout" |
| 42 android:layout_width="@dimen/drawer_width" | 49 android:layout_width="@dimen/drawer_width" |
| 43 android:layout_height="match_parent" | 50 android:layout_height="match_parent" |
| 44 android:layout_gravity="start" | 51 android:layout_gravity="start" |
| 45 android:paddingTop="@dimen/drawer_margin_large" | 52 android:paddingTop="@dimen/drawer_margin_large" |
| 46 android:orientation="vertical" | 53 android:orientation="vertical" |
| 47 android:background="#ffffff" > | 54 android:background="#ffffff" > |
| 48 | 55 |
| 49 <include layout="@layout/download_manager_ui_space_widget"/> | 56 <include layout="@layout/download_manager_ui_space_widget"/> |
| 50 | 57 |
| 51 <ListView | 58 <ListView |
| 52 android:id="@+id/section_list" | 59 android:id="@+id/section_list" |
| 53 android:layout_width="match_parent" | 60 android:layout_width="match_parent" |
| 54 android:layout_height="0dp" | 61 android:layout_height="0dp" |
| 55 android:layout_weight="1" | 62 android:layout_weight="1" |
| 56 android:divider="@null" | 63 android:divider="@null" |
| 57 android:dividerHeight="0dp" /> | 64 android:dividerHeight="0dp" /> |
| 58 </LinearLayout> | 65 </LinearLayout> |
| 59 | 66 |
| 60 </org.chromium.chrome.browser.download.ui.DownloadManagerUi> | 67 </org.chromium.chrome.browser.download.ui.DownloadManagerUi> |
| OLD | NEW |