Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(128)

Issue 21433: Perform HTTP authentication over a keep-alive connection.... (Closed)

Created:
10 years, 3 months ago by wtc
Modified:
8 years ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Perform HTTP authentication over a keep-alive connection. This is required for NTLM authentication. R=eroman BUG=6567, 6824 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9964

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 2

Patch Set 6 : Add || around identifiers in comments #

Patch Set 7 : Remove the DCHECK on next_state_ after the HandleAuthChallenge call #

Patch Set 8 : Last upload before checkin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+464 lines, -12 lines) Patch
M net/http/http_network_transaction.h View 1 2 3 4 5 6 7 4 chunks +14 lines, -0 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 2 3 4 5 6 7 6 chunks +104 lines, -12 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 2 3 4 5 6 7 1 chunk +346 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
wtc
eroman: please review the CL. darin: just FYI. http://codereview.chromium.org/21433/diff/1/2 File net/http/http_network_transaction.cc (right): http://codereview.chromium.org/21433/diff/1/2#newcode977 Line 977: ...
10 years, 3 months ago (2009-02-17 22:51:26 UTC) #1
eroman
will review this as soon as I get back. one quick comment as I was ...
10 years, 3 months ago (2009-02-17 23:10:47 UTC) #2
darin (slow to review)
so long as we can still do basic/digest auth over non-keep-alive connections, all should be ...
10 years, 3 months ago (2009-02-18 00:17:18 UTC) #3
wtc
Darin: Note that this CL will cause us to also do basic/digest auth over a ...
10 years, 3 months ago (2009-02-18 01:32:14 UTC) #4
eroman
LGTM (reviewed patchset 4). Thanks for all the tests. I wander if we will want ...
10 years, 3 months ago (2009-02-18 02:36:04 UTC) #5
wtc
I found that I missed another corner case: a response content length of 0. I ...
10 years, 3 months ago (2009-02-18 02:56:45 UTC) #6
eroman
I am not seeing what changed between revision 4 and 5 other than refactoring. This ...
10 years, 3 months ago (2009-02-18 03:34:02 UTC) #7
eroman
10 years, 3 months ago (2009-02-18 20:14:11 UTC) #8
lgtm

Powered by Google App Engine
This is Rietveld 408576698